From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.hengli.com.au, linville@tuxdriver.com,
netdev@vger.kernel.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] netpoll: use non-BH variant of RCU
Date: Fri, 3 Sep 2010 08:52:44 -0700 [thread overview]
Message-ID: <20100903155244.GC2413@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100903.083409.52185570.davem@davemloft.net>
On Fri, Sep 03, 2010 at 08:34:09AM -0700, David Miller wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Date: Thu, 2 Sep 2010 10:26:25 -0700
>
> > softirq: adjust error check
> >
> > The error check for _local_bh_enable_ip() warns on both in_irq() and
> > irqs_disabled(). The check for in_irq() is necessary, because a hardirq
> > might well have interrupted bh execution, in which case it is simply
> > not possible for the hardirq to exclude the bh that got interrupted.
> >
> > However, it is perfectly reasonable to disable bh while hardirqs are
> > disabled, and this in fact promotes common code. This commit therefore
> > removes the irqs_disabled() check.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Thank you, David!
Thanx, Paul
prev parent reply other threads:[~2010-09-03 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100810211932.GG2379@linux.vnet.ibm.com>
[not found] ` <20100810.163117.241919476.davem@davemloft.net>
[not found] ` <20100811220047.GH2516@linux.vnet.ibm.com>
[not found] ` <20100811.230936.183035599.davem@davemloft.net>
[not found] ` <20100812154213.GB2524@linux.vnet.ibm.com>
[not found] ` <20100813143904.GA27261@gondor.apana.org.au>
[not found] ` <20100813162912.GJ2511@linux.vnet.ibm.com>
2010-08-13 17:51 ` [PATCH] netpoll: use non-BH variant of RCU Herbert Xu
2010-08-15 6:50 ` David Miller
2010-09-02 17:26 ` Paul E. McKenney
2010-09-03 15:34 ` David Miller
2010-09-03 15:52 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903155244.GC2413@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox