From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829Ab0IDAyF (ORCPT ); Fri, 3 Sep 2010 20:54:05 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49741 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420Ab0IDAyE (ORCPT ); Fri, 3 Sep 2010 20:54:04 -0400 Date: Fri, 3 Sep 2010 17:58:31 -0700 From: Andrew Morton To: "Ira W. Snyder" Cc: linux-kernel@vger.kernel.org, Dan Williams , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] fsldma: fix missing header include Message-Id: <20100903175831.27bb56fc.akpm@linux-foundation.org> In-Reply-To: <20100904004724.GA4085@ovro.caltech.edu> References: <20100902194752.GA24861@ovro.caltech.edu> <20100903164033.6ae37727.akpm@linux-foundation.org> <20100904004724.GA4085@ovro.caltech.edu> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Sep 2010 17:47:24 -0700 "Ira W. Snyder" wrote: > On Fri, Sep 03, 2010 at 04:40:33PM -0700, Andrew Morton wrote: > > On Thu, 2 Sep 2010 12:47:52 -0700 > > "Ira W. Snyder" wrote: > > > > > The slab.h header is required to use the kmalloc() family of functions. > > > Due to recent kernel changes, this header must be directly included by > > > code that calls into the memory allocator. > > > > > > Signed-off-by: Ira W. Snyder > > > --- > > > > > > Without this patch, any code which includes this header fails to build. > > > > > > arch/powerpc/include/asm/fsldma.h | 1 + > > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/arch/powerpc/include/asm/fsldma.h b/arch/powerpc/include/asm/fsldma.h > > > index a67aeed..debc5ed 100644 > > > --- a/arch/powerpc/include/asm/fsldma.h > > > +++ b/arch/powerpc/include/asm/fsldma.h > > > @@ -11,6 +11,7 @@ > > > #ifndef __ARCH_POWERPC_ASM_FSLDMA_H__ > > > #define __ARCH_POWERPC_ASM_FSLDMA_H__ > > > > > > +#include > > > #include > > > > > > > It also needs list.h, but appears to get it via sheer luck. > > > > The functions in that header simply shouldn't have been inlined. > > > > It's peculiar that fsl_dma_slave_append() hardwires GFP_ATOMIC, whereas > > fsl_dma_slave_alloc() takes a gfp_t. > > > > Would you like a patch that moves the functions to drivers/dma/fsldma.c > and EXPORT_SYMBOL_GPL()'s them? Sure, thanks. Then I can harrass Dan with it ;) > I don't know the consequences to doing > so, which is why I avoided it when I wrote > arch/powerpc/include/asm/fsldma.h. The minimal fix for the bug was appropriate.