From: Greg KH <gregkh@suse.de>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: CAI Qian <caiqian@redhat.com>,
Dave Anderson <anderson@redhat.com>,
"tj@kernel.org" <tj@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: crash failure with 2.6.36-rc3 vmcore
Date: Sat, 4 Sep 2010 23:22:55 -0700 [thread overview]
Message-ID: <20100905062255.GA18184@suse.de> (raw)
In-Reply-To: <20100905050625.GA700@ericsson.com>
On Sat, Sep 04, 2010 at 10:06:25PM -0700, Guenter Roeck wrote:
> I browsed through the code a bit. Looks like the module owner will need to make
> the necessary changes. The code now seems to depend on kernel internal structure
> elements. Not sure if that is a good idea in the first place. At least for
> the attribute owner it will have to be changed to not depend on its existence.
>
> Of course, one could also argue that the field should be re-introduced in
> the kernel to make the utility work w/o changes. However, I don't think it
> would be a good idea to hold the kernel hostage for such problems.
You're kidding, right? You should have tools flexable to handle the
fact that the internal kernel structures change all the time like this.
If not, your tools are broken.
good luck,
greg k-h
next prev parent reply other threads:[~2010-09-05 6:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <837631540.119231283612666731.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-04 15:07 ` crash failure with 2.6.36-rc3 vmcore caiqian
2010-09-04 17:55 ` Guenter Roeck
2010-09-05 3:17 ` CAI Qian
2010-09-05 5:06 ` Guenter Roeck
2010-09-05 6:22 ` Greg KH [this message]
[not found] <471005677.1486991283866304732.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2010-09-07 13:35 ` Dave Anderson
[not found] <856089343.1931201283439399228.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-04 6:01 ` CAI Qian
2010-09-04 14:20 ` Greg KH
2010-09-04 14:43 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100905062255.GA18184@suse.de \
--to=gregkh@suse.de \
--cc=anderson@redhat.com \
--cc=caiqian@redhat.com \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox