* [PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues
@ 2010-09-04 23:09 Javier Martinez Canillas
2010-09-05 7:34 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2010-09-04 23:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Bill Pemberton, Arnaud Patard, Randy Dunlap,
Huang Weiyi, devel, linux-kernel
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
drivers/staging/xgifb/vb_setmode.c | 35 +++++++++++++++++------------------
1 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index cf6874b..bcd3083 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -399,21 +399,20 @@ void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo)
unsigned char XGISetModeNew(struct xgi_hw_device_info *HwDeviceExtension,
unsigned short ModeNo)
{
- unsigned short ModeIdIndex ;
- /* unsigned char *pVBInfo->FBAddr = HwDeviceExtension->pjVideoMemoryAddress ; */
- struct vb_device_info VBINF;
- struct vb_device_info *pVBInfo = &VBINF;
- pVBInfo->ROMAddr = HwDeviceExtension->pjVirtualRomBase ;
- pVBInfo->BaseAddr = (unsigned long)HwDeviceExtension->pjIOAddress ;
- pVBInfo->IF_DEF_LVDS = 0 ;
- pVBInfo->IF_DEF_CH7005 = 0 ;
- pVBInfo->IF_DEF_LCDA = 1 ;
- pVBInfo->IF_DEF_CH7017 = 0 ;
- pVBInfo->IF_DEF_CH7007 = 0 ; /* [Billy] 2007/05/14 */
- pVBInfo->IF_DEF_VideoCapture = 0 ;
- pVBInfo->IF_DEF_ScaleLCD = 0 ;
- pVBInfo->IF_DEF_OEMUtil = 0 ;
- pVBInfo->IF_DEF_PWD = 0 ;
+ unsigned short ModeIdIndex = 0;
+ struct vb_device_info VBINF;
+ struct vb_device_info *pVBInfo = &VBINF;
+ pVBInfo->ROMAddr = HwDeviceExtension->pjVirtualRomBase;
+ pVBInfo->BaseAddr = (unsigned long)HwDeviceExtension->pjIOAddress;
+ pVBInfo->IF_DEF_LVDS = 0;
+ pVBInfo->IF_DEF_CH7005 = 0;
+ pVBInfo->IF_DEF_LCDA = 1;
+ pVBInfo->IF_DEF_CH7017 = 0;
+ pVBInfo->IF_DEF_CH7007 = 0; /* [Billy] 2007/05/14 */
+ pVBInfo->IF_DEF_VideoCapture = 0;
+ pVBInfo->IF_DEF_ScaleLCD = 0;
+ pVBInfo->IF_DEF_OEMUtil = 0;
+ pVBInfo->IF_DEF_PWD = 0;
if ( HwDeviceExtension->jChipType >= XG20 ) /* kuku 2004/06/25 */
@@ -4444,9 +4443,9 @@ unsigned char XGI_SetCRT2Group301(unsigned short ModeNo,
struct xgi_hw_device_info *HwDeviceExtension,
struct vb_device_info *pVBInfo)
{
- unsigned short tempbx ,
- ModeIdIndex ,
- RefreshRateTableIndex ;
+ unsigned short tempbx,
+ ModeIdIndex = 0,
+ RefreshRateTableIndex;
tempbx=pVBInfo->VBInfo ;
pVBInfo->SetFlag |= ProgrammingCRT2 ;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues
2010-09-04 23:09 [PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues Javier Martinez Canillas
@ 2010-09-05 7:34 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-09-05 7:34 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Greg Kroah-Hartman, Bill Pemberton, Arnaud Patard, Randy Dunlap,
Huang Weiyi, devel, linux-kernel
On Sat, Sep 04, 2010 at 07:09:25PM -0400, Javier Martinez Canillas wrote:
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> drivers/staging/xgifb/vb_setmode.c | 35 +++++++++++++++++------------------
Sorry, this no longer applies due to some coding style cleanups in this
file done by someone else earlier today.
Can you redo this against the next linux-next tree and send me the new
version?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-05 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-04 23:09 [PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues Javier Martinez Canillas
2010-09-05 7:34 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox