* [PATCH 1/1] SOUND: wm8753, remove dead code
@ 2010-09-04 13:12 Jiri Slaby
2010-09-06 10:32 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2010-09-04 13:12 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, linux-kernel, jirislaby, Liam Girdwood,
Jaroslav Kysela
There is adangling code in wm8753_probe which is never executed.
Remove it.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@suse.cz>
---
sound/soc/codecs/wm8753.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index 4844232..4a945d3 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -1600,9 +1600,6 @@ static int wm8753_probe(struct snd_soc_codec *codec)
wm8753_add_widgets(codec);
return 0;
-
- run_delayed_work(&codec->delayed_work);
- return ret;
}
/* power down chip */
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] SOUND: wm8753, remove dead code
2010-09-04 13:12 [PATCH 1/1] SOUND: wm8753, remove dead code Jiri Slaby
@ 2010-09-06 10:32 ` Liam Girdwood
2010-09-06 10:44 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2010-09-06 10:32 UTC (permalink / raw)
To: Jiri Slaby
Cc: tiwai, alsa-devel, linux-kernel, jirislaby, Liam Girdwood,
Jaroslav Kysela, Mark Brown
On Sat, 2010-09-04 at 15:12 +0200, Jiri Slaby wrote:
> There is adangling code in wm8753_probe which is never executed.
> Remove it.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Liam Girdwood <lg@opensource.wolfsonmicro.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@suse.cz>
> ---
> sound/soc/codecs/wm8753.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
> index 4844232..4a945d3 100644
> --- a/sound/soc/codecs/wm8753.c
> +++ b/sound/soc/codecs/wm8753.c
> @@ -1600,9 +1600,6 @@ static int wm8753_probe(struct snd_soc_codec *codec)
> wm8753_add_widgets(codec);
>
> return 0;
> -
> - run_delayed_work(&codec->delayed_work);
> - return ret;
> }
>
> /* power down chip */
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] SOUND: wm8753, remove dead code
2010-09-06 10:32 ` Liam Girdwood
@ 2010-09-06 10:44 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-09-06 10:44 UTC (permalink / raw)
To: Liam Girdwood
Cc: Jiri Slaby, tiwai, alsa-devel, linux-kernel, jirislaby,
Liam Girdwood, Jaroslav Kysela
On Mon, Sep 06, 2010 at 11:32:30AM +0100, Liam Girdwood wrote:
> On Sat, 2010-09-04 at 15:12 +0200, Jiri Slaby wrote:
> > There is adangling code in wm8753_probe which is never executed.
> > Remove it.
> >
> > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Jiri, you should know to send copies of patches to maintainers. Applied
after digging out of a list folder.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-06 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-04 13:12 [PATCH 1/1] SOUND: wm8753, remove dead code Jiri Slaby
2010-09-06 10:32 ` Liam Girdwood
2010-09-06 10:44 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox