From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755677Ab0IFVQv (ORCPT ); Mon, 6 Sep 2010 17:16:51 -0400 Received: from kroah.org ([198.145.64.141]:57506 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406Ab0IFVQh (ORCPT ); Mon, 6 Sep 2010 17:16:37 -0400 Date: Mon, 6 Sep 2010 14:10:54 -0700 From: Greg KH To: Michal Nazarewicz Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Daniel Walker , FUJITA Tomonori , Hans Verkuil , Jonathan Corbet , KAMEZAWA Hiroyuki , Konrad Rzeszutek Wilk , Kyungmin Park , Marek Szyprowski , Mel Gorman , Minchan Kim , Pawel Osciak , Peter Zijlstra , Russell King , Zach Pfeffer , linux-kernel@vger.kernel.org Subject: Re: [RFCv5 8/9] mm: vcm: Sample driver added Message-ID: <20100906211054.GC5863@kroah.com> References: <262a5a5019c1f1a44d5793f7e69776e56f27af06.1283749231.git.mina86@mina86.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <262a5a5019c1f1a44d5793f7e69776e56f27af06.1283749231.git.mina86@mina86.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 06, 2010 at 08:33:58AM +0200, Michal Nazarewicz wrote: > --- /dev/null > +++ b/include/linux/vcm-sample.h Don't put "sample" code in include/linux/ please. That's just cluttering up the place, don't you think? Especially as no one else needs the file there... thanks, greg k-h