[PATCH 1/1] staging: xgifb: Removes unnecessary log

[PATCH 1/1] staging: xgifb: Removes unnecessary log

[Javier Martinez Canillas]

This patch fixes a compile warning in today linux-next.

The first version of this patch casted XGIFB_GET_INFO to unsigned long, but Greg suggest that I should use %p instead and that the whole message is just looney.

So this patch removes the unnecessary log.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
 drivers/staging/xgifb/XGI_main_26.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 7cd3e95..46e7088 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -3417,13 +3417,6 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
 
 		XGIfb_registered = 1;
 
-		printk(KERN_INFO "XGIfb: Installed XGIFB_GET_INFO ioctl (%lx)\n",
-		       XGIFB_GET_INFO);
-
-/*		printk(KERN_INFO "XGIfb: 2D acceleration is %s, scrolling mode %s\n",
-		     XGIfb_accel ? "enabled" : "disabled",
-		     XGIfb_ypan  ? "ypan" : "redraw");
-*/
 		printk(KERN_INFO "fb%d: %s frame buffer device, Version %d.%d.%02d\n",
 	       		fb_info->node, myid, VER_MAJOR, VER_MINOR, VER_LEVEL);
 
-- 
1.7.0.4

Re: [PATCH 1/1] staging: xgifb: Removes unnecessary log

[Greg KH]

On Tue, Sep 07, 2010 at 01:28:29AM -0400, Javier Martinez Canillas wrote:
> This patch fixes a compile warning in today linux-next.

Note, you need to fix up how your patches are generated.  [1/1] and then
[2/2] and then [3/3] would cause me to belive that I'm missing some
patches you would have sent out (1/2, 1/3, and 2/3).  Just use git
format-patch to generate them if you have a problem with them.

> The first version of this patch casted XGIFB_GET_INFO to unsigned long, but Greg suggest that I should use %p instead and that the whole message is just looney.

Please wrap your lines at 72 characters.

thanks,

greg k-h

Re: [PATCH 1/1] staging: xgifb: Removes unnecessary log

[Greg KH]

On Tue, Sep 07, 2010 at 01:28:29AM -0400, Javier Martinez Canillas wrote:
> This patch fixes a compile warning in today linux-next.
> 
> The first version of this patch casted XGIFB_GET_INFO to unsigned
> long, but Greg suggest that I should use %p instead and that the whole
> message is just looney.
> 
> So this patch removes the unnecessary log.

Unfortunatly it doesn't apply as you and Prashant seem to like to modify
the same file on the same day.  Prashant's patch is now in my tree, so
you need to redo this one.  I suggest you two get together and
coordinate this so I can stop rejecting every other patch from both of
you :)

thanks,

greg k-h

Re: [PATCH 1/1] staging: xgifb: Removes unnecessary log

[Javier Martinez Canillas]

>> So this patch removes the unnecessary log.
>
> Unfortunatly it doesn't apply as you and Prashant seem to like to modify
> the same file on the same day.  Prashant's patch is now in my tree, so
> you need to redo this one.  I suggest you two get together and
> coordinate this so I can stop rejecting every other patch from both of
> you :)
>
> thanks,
>
> greg k-h
>

Ok Greg, I will redo this patches. Thanks a lot

-- 
Best regards,

-----------------------------------------
Javier Martínez Canillas
+595 981 88 66 58