From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757457Ab0IGPSP (ORCPT ); Tue, 7 Sep 2010 11:18:15 -0400 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:22993 "EHLO VA3EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757059Ab0IGPSL (ORCPT ); Tue, 7 Sep 2010 11:18:11 -0400 X-SpamScore: -22 X-BigFish: VPS-22(zzbb2dK1432N98dN9371Pzz1202hzzz32i2a8h43h61h) X-Spam-TCS-SCL: 0:0 X-WSS-ID: 0L8DUE5-01-2RF-02 X-M-MSG: Date: Tue, 7 Sep 2010 17:15:41 +0200 From: Robert Richter To: Peter Zijlstra CC: Matt Domsch , Arjan van de Ven , Ingo Molnar , Stephane Eranian , Linus Torvalds , LKML , "H. Peter Anvin" Subject: Re: [PATCH] perf, x86: Disable perf if the BIOS got its grubby paws on the PMU Message-ID: <20100907151541.GA13563@erda.amd.com> References: <1283505227.1783.224.camel@laptop> <4C80FDF7.1080106@linux.intel.com> <20100903143258.GB373@auslistsprd01.us.dell.com> <1283525163.2050.105.camel@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1283525163.2050.105.camel@laptop> User-Agent: Mutt/1.5.20 (2009-06-14) X-Reverse-DNS: unknown Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > On 9/3/2010 2:13 AM, Peter Zijlstra wrote: > > > >+static void print_BIOS_fail(void) > > > >+{ > > > >+ printk(KERN_ERR "\n"); > > > >+ printk(KERN_ERR "=============================================\n"); > > > >+ printk(KERN_ERR "It appears the BIOS is actively using the PMU\n"); > > > >+ printk(KERN_ERR "this avoids Linux from using it, please de- \n"); > > > >+ printk(KERN_ERR "activate this BIOS feature or request a BIOS \n"); > > > >+ printk(KERN_ERR "update from your vendor. \n"); > > > >+ printk(KERN_ERR "=============================================\n"); I would rather prefer this: BIOS bug, cpu 1, invalid ... ... which is a much better information on one line, explains the bug and is also better parsable. I intend to implement messages like this. So maybe we could find consensus with this or something similar. A simple grep of dmesg will then give a list of BIOS bugs. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center