From: Robert Richter <robert.richter@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Matt Domsch <Matt_Domsch@dell.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
Stephane Eranian <eranian@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.kernel.org>
Subject: Re: [PATCH] perf, x86: Disable perf if the BIOS got its grubby paws on the PMU
Date: Tue, 7 Sep 2010 18:51:58 +0200 [thread overview]
Message-ID: <20100907165158.GB13563@erda.amd.com> (raw)
In-Reply-To: <20100907151541.GA13563@erda.amd.com>
On 07.09.10 17:15:41, Robert Richter wrote:
> > > > On 9/3/2010 2:13 AM, Peter Zijlstra wrote:
> > > > >+static void print_BIOS_fail(void)
> > > > >+{
> > > > >+ printk(KERN_ERR "\n");
> > > > >+ printk(KERN_ERR "=============================================\n");
> > > > >+ printk(KERN_ERR "It appears the BIOS is actively using the PMU\n");
> > > > >+ printk(KERN_ERR "this avoids Linux from using it, please de- \n");
> > > > >+ printk(KERN_ERR "activate this BIOS feature or request a BIOS \n");
> > > > >+ printk(KERN_ERR "update from your vendor. \n");
> > > > >+ printk(KERN_ERR "=============================================\n");
>
> I would rather prefer this:
>
> BIOS bug, cpu 1, invalid <register=value> ...
I got the note there is already a macro for this in kernel.h:
#define FW_BUG "[Firmware Bug]: "
So, we would have something like:
[Firmware Bug]: cpu 1, invalid <register=value> ...
in dmesg.
-Robert
>
> ... which is a much better information on one line, explains the bug
> and is also better parsable. I intend to implement messages like
> this. So maybe we could find consensus with this or something similar.
>
> A simple grep of dmesg will then give a list of BIOS bugs.
>
> -Robert
>
> --
> Advanced Micro Devices, Inc.
> Operating System Research Center
--
Advanced Micro Devices, Inc.
Operating System Research Center
prev parent reply other threads:[~2010-09-07 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 9:13 [PATCH] perf, x86: Disable perf if the BIOS got its grubby paws on the PMU Peter Zijlstra
2010-09-03 13:53 ` Arjan van de Ven
2010-09-03 14:32 ` Matt Domsch
2010-09-03 14:46 ` Peter Zijlstra
2010-09-07 15:15 ` Robert Richter
2010-09-07 16:51 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907165158.GB13563@erda.amd.com \
--to=robert.richter@amd.com \
--cc=Matt_Domsch@dell.com \
--cc=arjan@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@linux.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox