From: Greg KH <greg@kroah.com>
To: David Cross <david.cross@cypress.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] west bridge, block driver fixes
Date: Tue, 7 Sep 2010 16:54:53 -0700 [thread overview]
Message-ID: <20100907235453.GA12823@kroah.com> (raw)
In-Reply-To: <1283888253.7250.21.camel@odc-laptop>
On Tue, Sep 07, 2010 at 12:37:33PM -0700, David Cross wrote:
> This patch makes minor fixes to the block driver for locking issues,
> printk statements and minor change for a kernel update to 2.6.36.
> Please let me know if there are issues or concerns with this patch.
Again, you are doing at least 3 different things here, right? Please
split them out into 3 different patches.
Remember, one patch per logical change please.
> Signed-off-by: David Cross <david.cross@cypress.com>
>
> diff -uprN -X linux-next-vanilla/Documentation/dontdiff linux-next-vanilla/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c linux-next-incl-sdk/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c
> --- linux-next-vanilla/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c 2010-08-31 19:32:51.000000000 -0700
> +++ linux-next-incl-sdk/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c 2010-09-07 11:28:49.000000000 -0700
> @@ -202,7 +202,7 @@ static struct cyasblkdev_blk_data *cyasb
> if (bd) {
> bd->usage++;
> #ifndef NBDEBUG
> - cy_as_hal_print_message(
> + printk(KERN_INFO
> "cyasblkdev_blk_get: usage = %d\n", bd->usage) ;
> #endif
No, just use dev_dbg() here then you can drop the #ifdef.
Oh wait, it's the other way around? If you don't have debugging enabled
you want to print that message? Huh? Just drop the #ifndef and then
use dev_info() instead. That will properly print out the device and
driver that is being used here.
You can do that for all of your *hal_print_message() calls.
thanks,
greg k-h
prev parent reply other threads:[~2010-09-08 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 19:37 [PATCH] west bridge, block driver fixes David Cross
2010-09-07 21:09 ` Randy Dunlap
2010-09-07 23:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907235453.GA12823@kroah.com \
--to=greg@kroah.com \
--cc=david.cross@cypress.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox