From: Greg KH <greg@kroah.com>
To: David Cross <david.cross@cypress.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] west bridge, kconfig and hal fixes
Date: Tue, 7 Sep 2010 16:57:04 -0700 [thread overview]
Message-ID: <20100907235704.GC12823@kroah.com> (raw)
In-Reply-To: <1283887330.7250.6.camel@odc-laptop>
On Tue, Sep 07, 2010 at 12:22:10PM -0700, David Cross wrote:
First off, what's with the "Re:" of the Subject? What are you
responding to here?
> This patch contains the kconfig changes necessary to fix build errors
> that could come up in the linux-next version. It also includes an
> additional HAL layer for the west bridge CRAM interface.
Again, one patch per change, please break this up.
> The inclusion
> of this interface support did require the reorganization of some of the
> existing code, which is part of the reason for the size of the patch.
> Moving files and directories makes this patch seem larger than it really
> is.
If you use git you can send a patch that properly shows only what
changes even if the file is moved. Care to do that?
> The Kconfig changes are closely related to the inclusion of the CRAM
> HAL layer, and as such this patch is difficult to logically separate.
Why is it necessary?
> The linux-next tree does not seem to have a config for the zoom2, and
> trying to build it for that board seems to make the compilation break.
Why should the driver care about which arch it is built for? It should
build on _all_ arches, right?
> As such, the only thing that I tested was compilation using the two
> different HALs (one of which is added in this patch). Please let me know
> if there are problems or questions with this.
Why do you need a "HAL" at all here?
confused,
greg k-h
next prev parent reply other threads:[~2010-09-08 0:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5BFACB1451C1459BA8562A5561D0A4E6@stanford.edu>
2010-09-02 0:08 ` [PATCH] West Bridge Astoria Driver 2.6.35, Kconfig fixes David Cross
2010-09-02 1:37 ` Greg KH
2010-09-02 22:43 ` [PATCH] West Bridge Astoria Driver 2.6.35, Kconfig and HAL fixes David Cross
2010-09-05 5:17 ` Greg KH
2010-09-07 19:22 ` [PATCH] west bridge, kconfig and hal fixes David Cross
2010-09-07 23:57 ` Greg KH [this message]
2010-09-08 20:56 ` David Cross
2010-09-09 3:51 ` Greg KH
2010-09-02 22:47 ` [PATCH] West Bridge Astoria Driver 2.6.35, cyasgadget fixes and mpage_cleardirty David Cross
2010-09-05 5:20 ` Greg KH
2010-09-02 22:49 ` [PATCH] West Bridge Astoria Driver 2.6.35, minor block and device driver updates David Cross
2010-09-05 5:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907235704.GC12823@kroah.com \
--to=greg@kroah.com \
--cc=david.cross@cypress.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox