From: Greg KH <gregkh@suse.de>
To: walter harms <wharms@bfs.de>
Cc: Kulikov Vasiliy <segooon@gmail.com>,
kernel-janitors@vger.kernel.org,
David Cross <david.cross@cypress.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/14] staging: westbridge: improve error path
Date: Tue, 7 Sep 2010 17:23:47 -0700 [thread overview]
Message-ID: <20100908002347.GE15785@suse.de> (raw)
In-Reply-To: <4C85E6DE.3020409@bfs.de>
On Tue, Sep 07, 2010 at 09:16:46AM +0200, walter harms wrote:
>
>
> Greg KH schrieb:
> > On Mon, Sep 06, 2010 at 09:51:20AM +0200, walter harms wrote:
> >> the indention should be fixed also.
> >
> > Yes, the indentation for the whole file should be fixed, but that's not
> > what this patch was doing.
> >
> > Remember, a patch should only do one thing at a time.
> >
>
> that is true,
> but in this special case i nearly missed the #if because it is so hidden
> in the code. IMHO that is enough for an exception.
This whole driver needs major help. But again, one thing at a time
please.
thanks,
greg k-h
prev parent reply other threads:[~2010-09-08 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 18:32 [PATCH 09/14] staging: westbridge: improve error path Kulikov Vasiliy
2010-09-06 7:51 ` walter harms
2010-09-06 20:33 ` Greg KH
2010-09-07 7:16 ` walter harms
2010-09-08 0:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908002347.GE15785@suse.de \
--to=gregkh@suse.de \
--cc=david.cross@cypress.com \
--cc=devel@driverdev.osuosl.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox