Re: [PATCH] kbuild: fix oldnoconfig to do the right thing

Michal Marek
2010-09-08T11:56:10Z

On Sun, Sep 05, 2010 at 08:17:58AM +0200, Sam Ravnborg wrote:
> On Wed, Sep 01, 2010 at 11:21:30AM -0400, Kyle McMartin wrote:
> > From: Kyle McMartin <kyle@redhat.com>
> >
> > Commit 861b4ea4 broke oldnoconfig when removed the oldnoconfig checks on
> > if (input_mode == nonint_oldconfig ||
> > input_mode == oldnoconfig) {
> > if (input_mode == nonint_oldconfig &&
> > sym->name &&
> > !sym_is_choice_value(sym)) {
> > to avoid oldnoconfig chugging through the else stanza.
> >
> > Fix that to restore expected behaviour (which I've confirmed in the
> > Fedora kernel build that the configs end up looking the same.)
>
> I played aroud with this.
> I looks like the only difference I got was that before
> your patch oldnoconfig produced a lot of output to stdout.
> With your patch is was silent.
>
> The resulting config was the same.

I found that when running make oldnoconfig on the kconfig branch of
kbuild.git (which is currently a 2.6.35 + kconfig changes) against a
2.6.35-rc1 x86_64 defconfig, it mysteriously switches from
CONFIG_KERNEL_GZIP=y to CONFIG_KERNEL_LZO=y. With Kyle's patch it
doesn't do this. I applied the patch now.

Michal