From: Jean Delvare <khali@linux-fr.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: Add support for max6695 and max6696 to lm90 driver
Date: Wed, 8 Sep 2010 17:29:02 +0200 [thread overview]
Message-ID: <20100908172902.6ed57505@hyperion.delvare> (raw)
In-Reply-To: <20100908135654.GA11277@ericsson.com>
On Wed, 8 Sep 2010 06:56:54 -0700, Guenter Roeck wrote:
> Too bad - registers 0x16 and 0x17 exist on both 6658 and 6659. So the only way to detect 6659
> would be the address (0x4d or 0x4e), and we would mis-detect it on 0x4c. Is that worth it ?
I'd say adding support for the MAX6659 is worth it. Just don't add
detection. That is, all of MAX6657, 6658 and 6658 should be detected as
max6657, which has the minimum set of features. But if someone declares
a "max6659" device either as part of the platform data or from
user-space, then the driver should expose all the chip features.
Deal?
--
Jean Delvare
next prev parent reply other threads:[~2010-09-08 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 22:34 [PATCH] hwmon: Add support for max6695 and max6696 to lm90 driver Guenter Roeck
2010-09-06 16:12 ` Jean Delvare
2010-09-07 2:00 ` Guenter Roeck
2010-09-07 7:43 ` Jean Delvare
2010-09-08 10:28 ` Guenter Roeck
2010-09-08 11:48 ` Jean Delvare
2010-09-08 13:56 ` Guenter Roeck
2010-09-08 15:29 ` Jean Delvare [this message]
2010-09-08 18:30 ` Guenter Roeck
2010-09-08 19:44 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908172902.6ed57505@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox