From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756054Ab0IHPyZ (ORCPT ); Wed, 8 Sep 2010 11:54:25 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:44805 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755177Ab0IHPyU convert rfc822-to-8bit (ORCPT ); Wed, 8 Sep 2010 11:54:20 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=B4MTf5snsLhjvuLnF1wmP2As5BZWQreKDsoEe8q5iAUfsbtTfP6hc3wRhp9aQXfwec xRlHLmzg3joIQ1BF0Z+qw2X0hAa5zRUkaZqbgfQQ0hLD9EQP4Iz+Yn0m/o3PRIqGbGcT uKBG+IS9I21lBmVtKoLJkzmX/izr7UnovAp98= From: Marek Vasut Organization: Hack&Dev To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337 Date: Wed, 8 Sep 2010 17:54:15 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.34-1-amd64; KDE/4.4.5; x86_64; ; ) Cc: Haojian Zhuang , "Mark F. Brown" , Eric Miao , Haojian Zhuang , "linux-kernel" References: <1283914607-10570-1-git-send-email-mark.brown314@gmail.com> <1283914607-10570-4-git-send-email-mark.brown314@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201009081754.15515.marek.vasut@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne St 8. září 2010 07:34:24 Haojian Zhuang napsal(a): > On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown wrote: > > Signed-off-by: Mark F. Brown > > --- > > arch/arm/mach-mmp/teton_bga.c | 10 ++++++++++ > > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-mmp/teton_bga.c > > b/arch/arm/mach-mmp/teton_bga.c index bbeda5c..8e5801c 100644 > > --- a/arch/arm/mach-mmp/teton_bga.c > > +++ b/arch/arm/mach-mmp/teton_bga.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "common.h" > > > > @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata > > = { GPIO110_KP_MKIN0, > > GPIO111_KP_MKOUT7, > > GPIO112_KP_MKOUT6, > > + > > + /* i2c bus */ > > + GPIO105_CI2C_SDA, > > + GPIO106_CI2C_SCL, > > }; > > > > static unsigned int teton_bga_matrix_key_map[] = { > > @@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data > > teton_bga_keypad_info __initdata = { .debounce_interval = 30, > > }; > > > > +static struct i2c_board_info teton_bga_i2c_info[] __initdata = { > > + { I2C_BOARD_INFO("ds1337", 0x68), }, > > +}; > > + > > I don't have the schematic of teton. But RTC chips should always has > an irq pin. Is it also connected in your platform? I think this one doesn't, but I haven't checked. Cheers > > > static void __init teton_bga_init(void) > > { > > mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config)); > > @@ -59,6 +68,7 @@ static void __init teton_bga_init(void) > > /* on-chip devices */ > > pxa168_add_uart(1); > > pxa168_add_keypad(&teton_bga_keypad_info); > > + pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info)); > > } > > > > MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform") > > -- > > 1.7.0.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" > > in the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel