Re: [RFC 02/22] configfs: Add struct configfs_item_operations->check_link() in configfs_unlink()

Joel Becker
2010-09-02T06:52:06Z

On Thu, Sep 02, 2010 at 12:31:07AM -0400, Konrad Rzeszutek Wilk wrote:
> On Monday 30 August 2010 05:20:25 Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> >
> > This patch adds a optional struct configfs_item_operations->check_link()
> > check called in fs/configfs/symlink.c:configfs_unlink() that can be used by
> > configfs consumers to check for an explict struct config_group dependence
> > with active symlink and fail with -EPERM before the unlink(2) syscall is
> > allowed to occur.
> >
> > Currently without this patch, there is not a method that a consumer can
> > tell configfs_unlink() that it needs to fail for this particular case.
> > Allowing ->check_link() to propigate up the errno to VFS is also another
> > option for the call, but currently for TCM using the existing -EPERM in
> > configfs_unlink() is fine here.
> >
> > Note this patch is used by TCM v4 generic configfs fabric module
> > infrastructure to allow explict Initiator Port MappedLUNs symlinks to
> > create a dependency for the fabric TPG Port LUNs living in a configfs group
> > that is not a direct struct config_group parent.
> >
> > Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>

I NAK'd this a while back. I'm willing to be convinced, but so
far it remains that way.

Joel

--

Life's Little Instruction Book #109

"Know how to drive a stick shift."

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127