From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755211Ab0IIOy7 (ORCPT ); Thu, 9 Sep 2010 10:54:59 -0400 Received: from mail.vyatta.com ([76.74.103.46]:46860 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753286Ab0IIOy5 (ORCPT ); Thu, 9 Sep 2010 10:54:57 -0400 Date: Thu, 9 Sep 2010 07:54:55 -0700 From: Stephen Hemminger To: Joe Perches Cc: Jesse Barnes , linux-pci , LKML Subject: Re: [PATCH] include/linux/pci.h: Make struct pci_driver.name const char * Message-ID: <20100909075455.0cf3d3a5@nehalam> In-Reply-To: <1284017884.24986.93.camel@Joe-Laptop> References: <1284017884.24986.93.camel@Joe-Laptop> Organization: Vyatta X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 09 Sep 2010 00:38:04 -0700 Joe Perches wrote: > As far as I can tell, name is never modified. > > This would allow names to be assigned > from variables in non-writable sections. > > static const foo[] = "bar"; > > struct pci_driver baz = { > .name = foo; > }; > > Signed-off-by: Joe Perches > --- I already sent same patch to Jesse