From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
linux-kernel@vger.kernel.org, Jean Delvare <khali@linux-fr.org>
Subject: Re: [lm-sensors] [PATCH] lm75: some optimisations
Date: Thu, 9 Sep 2010 10:55:37 -0700 [thread overview]
Message-ID: <20100909175537.GA16681@ericsson.com> (raw)
In-Reply-To: <1284052336-25864-1-git-send-email-shubhrajyoti@ti.com>
General comments:
- Please select a more descriptive headline, such as
hwmon: lm75: Add __devinit and __devexit section initializers
- It is useful to provide the patch version to reduce confusion and enable
version tracking.
Example:
[PATCH v3] hwmon: lm75: Add __devinit and __devexit section initializers
- Please cc linux-kernel@vger.kernel.org and Jean Delvare <khali@linux-fr.org>.
On Thu, Sep 09, 2010 at 01:12:16PM -0400, Shubhrajyoti D wrote:
> - updating with Guenter's comments
>
This and other patch version related comments should be below the --- line.
Otherwise, it will end up in the commit log, which isn't really useful.
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Assuming you make above changes and resubmit, feel free to add
Reviewed-by: Guenter Roeck <guenter.roeck@ericsson.com>
Guenter
> ---
> drivers/hwmon/lm75.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index ab5b87a..028f961 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -134,7 +134,7 @@ static const struct attribute_group lm75_group = {
>
> /* device probe and removal */
>
> -static int
> +static int __devinit
> lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)
> {
> struct lm75_data *data;
> @@ -196,7 +196,7 @@ exit_free:
> return status;
> }
>
> -static int lm75_remove(struct i2c_client *client)
> +static int __devexit lm75_remove(struct i2c_client *client)
> {
> struct lm75_data *data = i2c_get_clientdata(client);
>
> @@ -325,7 +325,7 @@ static struct i2c_driver lm75_driver = {
> .pm = LM75_DEV_PM_OPS,
> },
> .probe = lm75_probe,
> - .remove = lm75_remove,
> + .remove = __devexit_p(lm75_remove),
> .id_table = lm75_ids,
> .detect = lm75_detect,
> .address_list = normal_i2c,
> --
> 1.7.0.4
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next parent reply other threads:[~2010-09-09 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1284052336-25864-1-git-send-email-shubhrajyoti@ti.com>
2010-09-09 17:55 ` Guenter Roeck [this message]
2010-09-09 18:11 ` [lm-sensors] [PATCH] lm75: some optimisations Jean Delvare
2010-09-13 4:10 ` Valdis.Kletnieks
2010-09-13 8:03 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909175537.GA16681@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox