From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754869Ab0IIRz7 (ORCPT ); Thu, 9 Sep 2010 13:55:59 -0400 Received: from imr3.ericy.com ([198.24.6.13]:56658 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831Ab0IIRz5 (ORCPT ); Thu, 9 Sep 2010 13:55:57 -0400 Date: Thu, 9 Sep 2010 10:55:37 -0700 From: Guenter Roeck To: Shubhrajyoti D CC: "lm-sensors@lm-sensors.org" , linux-kernel@vger.kernel.org, Jean Delvare Subject: Re: [lm-sensors] [PATCH] lm75: some optimisations Message-ID: <20100909175537.GA16681@ericsson.com> References: <1284052336-25864-1-git-send-email-shubhrajyoti@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1284052336-25864-1-git-send-email-shubhrajyoti@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org General comments: - Please select a more descriptive headline, such as hwmon: lm75: Add __devinit and __devexit section initializers - It is useful to provide the patch version to reduce confusion and enable version tracking. Example: [PATCH v3] hwmon: lm75: Add __devinit and __devexit section initializers - Please cc linux-kernel@vger.kernel.org and Jean Delvare . On Thu, Sep 09, 2010 at 01:12:16PM -0400, Shubhrajyoti D wrote: > - updating with Guenter's comments > This and other patch version related comments should be below the --- line. Otherwise, it will end up in the commit log, which isn't really useful. > Signed-off-by: Shubhrajyoti D Assuming you make above changes and resubmit, feel free to add Reviewed-by: Guenter Roeck Guenter > --- > drivers/hwmon/lm75.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index ab5b87a..028f961 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -134,7 +134,7 @@ static const struct attribute_group lm75_group = { > > /* device probe and removal */ > > -static int > +static int __devinit > lm75_probe(struct i2c_client *client, const struct i2c_device_id *id) > { > struct lm75_data *data; > @@ -196,7 +196,7 @@ exit_free: > return status; > } > > -static int lm75_remove(struct i2c_client *client) > +static int __devexit lm75_remove(struct i2c_client *client) > { > struct lm75_data *data = i2c_get_clientdata(client); > > @@ -325,7 +325,7 @@ static struct i2c_driver lm75_driver = { > .pm = LM75_DEV_PM_OPS, > }, > .probe = lm75_probe, > - .remove = lm75_remove, > + .remove = __devexit_p(lm75_remove), > .id_table = lm75_ids, > .detect = lm75_detect, > .address_list = normal_i2c, > -- > 1.7.0.4 > > > _______________________________________________ > lm-sensors mailing list > lm-sensors@lm-sensors.org > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors