From: Oleg Nesterov <oleg@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Roland McGrath <roland@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] exec: don't turn PF_KTHREAD off when command not found
Date: Thu, 9 Sep 2010 22:39:20 +0200 [thread overview]
Message-ID: <20100909203920.GA3057@redhat.com> (raw)
In-Reply-To: <20100909180236.C94C.A69D9226@jp.fujitsu.com>
On 09/09, KOSAKI Motohiro wrote:
>
> I guess this is only theorical issue because now any kthread don't
> call do_execve() directly.
Yes, I think that kthread should always exit if exec fails.
Otherwise we can "trust" the thread, just suppose that exec fails
after exec_mmap() succeeds.
But,
> but anyway fixing would be better.
Agreed. It looks better if we clear PF_KTHREAD after the point-of-no-return,
and the patch saves one ->flags modification.
Oleg.
next prev parent reply other threads:[~2010-09-09 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 9:03 [PATCH] exec: don't turn PF_KTHREAD off when command not found KOSAKI Motohiro
2010-09-09 20:39 ` Oleg Nesterov [this message]
2010-09-10 6:12 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909203920.GA3057@redhat.com \
--to=oleg@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox