From: Andy Whitcroft <apw@canonical.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add warnings for static char that could be static const char
Date: Fri, 10 Sep 2010 10:06:15 +0100 [thread overview]
Message-ID: <20100910090615.GA3644@shadowen.org> (raw)
In-Reply-To: <AANLkTin+twU1y_C6jfNDXruuoVncEivRO=2=1Jg69Xe=@mail.gmail.com>
On Thu, Sep 09, 2010 at 03:24:14PM -0400, Mike Frysinger wrote:
> On Thu, Sep 9, 2010 at 15:21, Joe Perches wrote:
> > Add warnings for possible missing const uses of
> > static char foo[] = "bar"
> > that could be
> > static const char foo[] = "bar"
> > and
> > static const char *foo[] = {"bar", "baz"}
> > that could be
> > static const char * const foo[] = {"bar", "baz"}
>
> guess you missed my last e-mail about not bothering checking the
> static or the contents :)
>
> > + if ($line =~ /\bconst\s+char\s*\*\s*(\w+)\s*\[\s*\]/) {
> -mike
Could you elucidate on that comment Mike, perhaps copy those comments
here.
-apw
next prev parent reply other threads:[~2010-09-10 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 18:22 [rfc patch] treewide: Convert "static const char <*> foo[] =" to "static const char <*> const foo[] =" Joe Perches
2010-09-09 18:29 ` Mike Frysinger
2010-09-09 18:48 ` Joe Perches
2010-09-09 19:16 ` Mike Frysinger
2010-09-09 19:33 ` Joe Perches
2010-09-09 19:40 ` Mike Frysinger
2010-09-09 19:48 ` Joe Perches
2010-09-09 19:50 ` Mike Frysinger
2010-09-09 20:05 ` Joe Perches
[not found] ` <SNT104-W3438BE3FC4EAC0A537D57EBA900@phx.gbl>
2011-04-19 13:59 ` Joe Perches
2010-09-09 19:21 ` [PATCH] scripts/checkpatch.pl: Add warnings for static char that could be static const char Joe Perches
2010-09-09 19:24 ` Mike Frysinger
2010-09-10 9:06 ` Andy Whitcroft [this message]
2010-09-10 9:30 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910090615.GA3644@shadowen.org \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox