Re: RFC: get_maintainer.pl: append reason for cc to the name by default

Ted Ts'o
2010-09-27T18:21:35Z

On Mon, Sep 27, 2010 at 07:00:26PM +0200, Florian Mickler wrote:
>
> Another improvement (beyond finding a decent heuristic based on the
> artifacts 'authorship', 'signed-off-by', 'reviewed-by', 'acked-by',
> 'committer' and nr-of-lines-changed.. and maybe time) is probably to
> not make an arbitrarily 1-Year-Back cut-off, but to check the last N
> commits on that region of the tree. (I'm thinking of the more
> "settled down" areas of the tree here)
> But let's see what I come up with...

I'd suggest a "stop list" of keywords that would cause a commit not be
considered at all. i.e., words like "trivial" (the trivial tree often
bypasses the subsystem maintainer, and you don't want to identify
someone as the maintainer just because they submitted a change to
change "colour" to "color"), "checkpatch", or "cleanup".

The other thing I'd suggest is try to figure out hueristics when the
git log analysis should be expanded beyond the file which was
modified, to the subdirctory. That is, if the patch touches a file
that rarely changes except for one spelling fix in the past year, but
the subsystem or device driver has activity in other files in that
subdirectory, it would be nice if get_maintainer.pl at least _tried_
to figure out this case of (for example)
drivers/media/video/omap/omap_voutlib.c has only one change in the
past year, and doesn't have an entry in MAINTAINERS, the history of
the subdirectory drivers/media/video/omap/ might be a better thing to
use when deciding who to bug about some trivial spelling chnage in
omap_voutlib.c.

Really, though, the right answer is to keep the MAINTAINERS file up to
date enough that we don't have to resort to having scripts attempt to
solve the AI problem. (I've argued for not even trying, but clearly
people who have tried to argue for that have lost that battle; enough
people seem to think it's worth while to make wild guesses even though
the script is called get_maintainer.pl, and not
get_maintainer_or_make_wild_stabs_in_the_dark.pl.)

- Ted

P.S. Wouldn't it be better to train kernel newbies how to read
through the output of git log themselves? I'm not sure that training
people to rely blindly on dumb scripts is in the end actually going to
be doing ourselves and the whole community a service. Sigh....