From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Tony Lindgren <tony@atomide.com>, Mike Galbraith <efault@gmx.de>
Subject: [RFC patch 2/2] sched: sleepers coarse granularity on wakeup
Date: Sat, 11 Sep 2010 13:37:34 -0400 [thread overview]
Message-ID: <20100911174003.227776749@efficios.com> (raw)
In-Reply-To: 20100911173732.551632040@efficios.com
[-- Attachment #1: sched-sleeper-coarse-gran.patch --]
[-- Type: text/plain, Size: 2786 bytes --]
Keep a larger granularity for awakened sleepers, so the "FAIR_SLEEPER" feature
is not affected by shrinking granularity.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
include/linux/sched.h | 1 +
kernel/sched.c | 1 +
kernel/sched_debug.c | 1 +
kernel/sched_fair.c | 11 +++++++++++
4 files changed, 14 insertions(+)
Index: linux-2.6-lttng.git/kernel/sched_fair.c
===================================================================
--- linux-2.6-lttng.git.orig/kernel/sched_fair.c
+++ linux-2.6-lttng.git/kernel/sched_fair.c
@@ -70,6 +70,11 @@ static unsigned int sched_nr_latency = 3
static unsigned int sched_nr_latency_max = 8;
/*
+ * Runtime slice given to awakened sleepers.
+ */
+unsigned int sysctl_sched_sleeper_wakeup_slice = 2000000ULL;
+
+/*
* After fork, child runs first. If set to 0 (default) then
* parent will (try to) run first.
*/
@@ -765,6 +770,7 @@ place_entity(struct cfs_rq *cfs_rq, stru
thresh >>= 1;
vruntime -= thresh;
+ se->sleeper_wakeup_slice = sysctl_sched_sleeper_wakeup_slice;
}
/* ensure we never gain time by being placed backwards. */
@@ -881,6 +887,11 @@ check_preempt_tick(struct cfs_rq *cfs_rq
if (!sched_feat(WAKEUP_PREEMPT))
return;
+ if (delta_exec < curr->sleeper_wakeup_slice)
+ return;
+ else
+ curr->sleeper_wakeup_slice = 0;
+
if (delta_exec < __sched_gran(cfs_rq->nr_running))
return;
Index: linux-2.6-lttng.git/include/linux/sched.h
===================================================================
--- linux-2.6-lttng.git.orig/include/linux/sched.h
+++ linux-2.6-lttng.git/include/linux/sched.h
@@ -1132,6 +1132,7 @@ struct sched_entity {
u64 prev_sum_exec_runtime;
u64 nr_migrations;
+ unsigned long sleeper_wakeup_slice;
#ifdef CONFIG_SCHEDSTATS
struct sched_statistics statistics;
Index: linux-2.6-lttng.git/kernel/sched.c
===================================================================
--- linux-2.6-lttng.git.orig/kernel/sched.c
+++ linux-2.6-lttng.git/kernel/sched.c
@@ -2422,6 +2422,7 @@ static void __sched_fork(struct task_str
p->se.sum_exec_runtime = 0;
p->se.prev_sum_exec_runtime = 0;
p->se.nr_migrations = 0;
+ p->se.sleeper_wakeup_slice = 0;
#ifdef CONFIG_SCHEDSTATS
memset(&p->se.statistics, 0, sizeof(p->se.statistics));
Index: linux-2.6-lttng.git/kernel/sched_debug.c
===================================================================
--- linux-2.6-lttng.git.orig/kernel/sched_debug.c
+++ linux-2.6-lttng.git/kernel/sched_debug.c
@@ -334,6 +334,7 @@ static int sched_debug_show(struct seq_f
PN(sysctl_sched_std_granularity);
PN(sysctl_sched_wakeup_granularity);
PN(sysctl_sched_child_runs_first);
+ PN(sysctl_sched_sleeper_wakeup_slice);
P(sysctl_sched_features);
#undef PN
#undef P
next prev parent reply other threads:[~2010-09-11 17:40 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 17:37 [RFC patch 0/2] sched: dynamically adapt granularity with nr_running Mathieu Desnoyers
2010-09-11 17:37 ` [RFC patch 1/2] " Mathieu Desnoyers
2010-09-11 18:57 ` Peter Zijlstra
2010-09-11 19:21 ` Linus Torvalds
2010-09-11 20:36 ` Peter Zijlstra
2010-09-11 20:45 ` Peter Zijlstra
2010-09-11 20:52 ` Linus Torvalds
2010-09-12 9:07 ` Peter Zijlstra
2010-09-11 20:48 ` Linus Torvalds
2010-09-12 9:06 ` Peter Zijlstra
2010-09-12 9:14 ` Peter Zijlstra
2010-09-12 20:39 ` Mathieu Desnoyers
2010-09-13 12:54 ` Peter Zijlstra
2010-09-12 20:34 ` Mathieu Desnoyers
2010-09-13 12:53 ` Peter Zijlstra
2010-09-13 4:35 ` Mike Galbraith
2010-09-13 8:41 ` Peter Zijlstra
2010-09-13 11:22 ` Ingo Molnar
2010-09-13 13:52 ` Steven Rostedt
2010-09-13 13:54 ` Peter Zijlstra
2010-09-13 14:02 ` Peter Zijlstra
2010-09-13 14:21 ` Ingo Molnar
2010-09-11 20:52 ` Mathieu Desnoyers
2010-09-11 19:57 ` Mathieu Desnoyers
2010-09-12 10:41 ` Peter Zijlstra
2010-09-12 20:37 ` Mathieu Desnoyers
2010-09-13 12:53 ` Peter Zijlstra
2010-09-13 13:15 ` Peter Zijlstra
2010-09-13 13:56 ` Mathieu Desnoyers
2010-09-13 14:16 ` Peter Zijlstra
2010-09-13 14:43 ` Steven Rostedt
2010-09-13 15:25 ` Mathieu Desnoyers
2010-09-13 15:39 ` Steven Rostedt
2010-09-13 16:16 ` [RFC PATCH] check_preempt_tick should not compare vruntime with wall time Mathieu Desnoyers
2010-09-13 16:36 ` Linus Torvalds
2010-09-13 17:45 ` Mathieu Desnoyers
2010-09-13 17:51 ` Linus Torvalds
2010-09-13 18:01 ` Mathieu Desnoyers
2010-09-13 18:10 ` Steven Rostedt
2010-09-13 18:03 ` Ingo Molnar
2010-09-13 18:19 ` Mathieu Desnoyers
2010-09-13 18:23 ` [PATCH] sched: Improve latencies under load by decreasing minimum scheduling granularity Ingo Molnar
2010-09-13 18:28 ` Joe Perches
2010-09-13 19:44 ` Linus Torvalds
2010-09-13 20:00 ` Ingo Molnar
2010-09-13 18:19 ` [RFC PATCH] check_preempt_tick should not compare vruntime with wall time Ingo Molnar
2010-09-13 17:36 ` Ingo Molnar
2010-09-13 17:56 ` Mathieu Desnoyers
2010-09-14 2:10 ` Mike Galbraith
2010-09-13 14:44 ` [RFC patch 1/2] sched: dynamically adapt granularity with nr_running Mike Galbraith
[not found] ` <1284386179.10436.6.camel@marge.simson.net>
2010-09-13 15:53 ` Peter Zijlstra
2010-09-13 18:04 ` [RFC][PATCH] sched: Improve tick preemption Peter Zijlstra
2010-09-14 2:27 ` [RFC patch 1/2] sched: dynamically adapt granularity with nr_running Mike Galbraith
2010-09-12 6:14 ` Ingo Molnar
2010-09-12 7:21 ` Mike Galbraith
2010-09-12 18:16 ` Mathieu Desnoyers
2010-09-13 4:13 ` Mike Galbraith
2010-09-13 6:41 ` Ingo Molnar
2010-09-13 7:08 ` Mike Galbraith
2010-09-13 7:35 ` Mike Galbraith
2010-09-13 8:35 ` Peter Zijlstra
2010-09-13 9:16 ` Mike Galbraith
2010-09-13 9:37 ` Peter Zijlstra
2010-09-13 9:50 ` Mike Galbraith
2010-09-13 9:55 ` Peter Zijlstra
2010-09-13 10:06 ` Mike Galbraith
2010-09-13 10:45 ` Peter Zijlstra
2010-09-13 11:43 ` Peter Zijlstra
2010-09-13 11:49 ` Peter Zijlstra
2010-09-13 12:32 ` Mike Galbraith
2010-09-13 20:19 ` Mathieu Desnoyers
2010-09-13 20:56 ` Mathieu Desnoyers
2010-09-12 18:13 ` Mathieu Desnoyers
2010-09-12 23:44 ` Mathieu Desnoyers
2010-09-11 17:37 ` Mathieu Desnoyers [this message]
2010-09-12 12:44 ` [RFC patch 0/2] " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100911174003.227776749@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=akpm@linux-foundation.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox