Re: [PATCH] get_maintainer.pl: append reason for cc to the name by default

Joe Perches
2010-09-14T23:15:44Z

On Tue, 2010-09-14 at 10:19 -0700, Eric W. Biederman wrote:
> Florian Mickler <florian@mickler.org> writes:
> > On Mon, 13 Sep 2010 00:57:45 -0700
> > Joe Perches <joe@perches.com> wrote:
> >> On Mon, 2010-09-13 at 00:16 -0700, Eric W. Biederman wrote:
> >> > It is trivial for a human to look at a git log and see which changes
> >> > were just global cleanups and which changes were actual maintenance.
> >> > Apparently get_maintainers doesn't have that ability.
> >> Do you have a useful, trivial or non-trivial algorithm
> >> to suggest or is that soft commenting? All I'll say is
> >> AI can be a surprisingly difficult field.
> > :) indeed.
> Which is why the tool needs to assist a person in doing the work.
> Please deliver a tool and not a broken solution.

Please suggest or implement improvements instead of merely asking
for something better.

> > It is easy to make get_maintainer.pl output less people.
> > What is not easy is to get it to decrease false-positives while
> > not decreasing it's detection rate.
> What is needed is something other than output that is a list of
> email addresses.

> email address foo had x% of non-author signed off bys
> email address foo had y% of author signed off bys
> email address foo had y% of author commits.
> email address foo came from the Maintainers file.

Already implemented.

Use --git --rolestats

> Additionally for email addresses that hit less often a list
> of patch subject titles, and truncated sha1 patch ids. So
> with luck you can tell at a glance the person is of interest
> and if not you can look at their commits quickly and see.

Use git. There's no reason to reimplement what git does.

> Which means in time every long time developer will be copied on every
> patch.

No, it doesn't mean that. Inactive developers don't get listed
by the tool.

> And right now get_maintainer.pl is decreasing the relevancy of cc lines
> in commits, which if get_maintainers.pl is used enough could be a
> vicious circle.

I don't see that get_maintainer does what you suggest it does.
Find some examples and publish them.