Re: [PATCH] get_maintainer.pl: append reason for cc to the name by default

Florian Mickler
2010-09-11T09:34:08Z

On Fri, 10 Sep 2010 08:12:37 -0700
Joe Perches <joe@perches.com> wrote:

> On Fri, 2010-09-10 at 13:11 +0200, Florian Mickler wrote:
> > On Fri, 10 Sep 2010 02:42:47 -0700
> > Joe Perches <joe@perches.com> wrote:
> > > On Fri, 2010-09-10 at 11:33 +0200, florian@mickler.org wrote:
> > > > The script get_maintainer.pl is a very useful tool for deploying changes
> > > > made to the kernel. Among others it searches not only the MAINTAINERS
> > > > file but also the git history for people to send patches to.\
> > > []
> > > > By appending a a note of the reason for the cc in the name, the reason
> > > > becomes clear and the receiving side is relieved from feeling obliged to
> > > > check the patch while the sending side has a chance to adapt the
> > > > cc'list to their liking.
> > > I don't like reading annotated email names myself.
> > Btw, why? I think it is a great way to show that it was done in an
> > automated fashion.
>
> More stuff than necessary to read, requires effort to find next.

next what?

I think the normal case is to ignore the name tag. It is only if you
really get many many emails that you will begin to filter for these
role-tags. And then you will probably do it in an automated fashion.

> Fewer names in visual field.

ok. But anybody who cares about his patch submission deeply can edit
the cc'list before sending. And then he is also likely to trim the
cc'list by leaving out people that did only trivial spelling fixes or
renamed stuff, or flamed them the last time.

>
> Also, it can affect systems that automatically add email addresses
> to an address directory as it could store the entire content
> before the < as the name.

I think any system that relies on input it can not control has to deal
with these kind of stuff anyway. (Be it typo's or just plain wrong
names, or surename<->name switcheroos...)
So I don't think this is that big a concern.

Cheers,
Flo