public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Nico Schottelius <nico-linux-20100709@schottelius.org>,
	mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	a.p.zijlstra@chello.nl, torvalds@linux-foundation.org,
	peterz@infradead.org, flo@xssn.at, lenb@kernel.org,
	jbarnes@virtuousgeek.org, suresh.b.siddha@intel.com,
	tglx@linutronix.de, rjw@sisk.pl,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/urgent] x86, tsc: Fix a preemption leak in restore_sched_clock_state()
Date: Mon, 13 Sep 2010 10:46:19 +0200	[thread overview]
Message-ID: <20100913084619.GC23741@elte.hu> (raw)
In-Reply-To: <20100913074233.GA2674@schottelius.org>


* Nico Schottelius <nico-linux-20100709@schottelius.org> wrote:

> Good morning,
> 
> tip-bot for Peter Zijlstra [Sat, Sep 11, 2010 at 07:49:07AM +0000]:
> > Commit-ID:  55496c896b8a695140045099d4e0175cf09d4eae
> > Gitweb:     http://git.kernel.org/tip/55496c896b8a695140045099d4e0175cf09d4eae
> > Author:     Peter Zijlstra <peterz@infradead.org>
> > AuthorDate: Fri, 10 Sep 2010 22:32:53 +0200
> > Committer:  Ingo Molnar <mingo@elte.hu>
> > CommitDate: Sat, 11 Sep 2010 09:47:07 +0200
> > 
> > x86, tsc: Fix a preemption leak in restore_sched_clock_state()
> 
> running 2.6.36-rc3-00464-g84e1d83 now, which includes that fix.
> 
> So far no resume issues, but the backlight does not power on again,
> if the lid is opened.

That's probably unrelated.

> Manually triggering display backlight increase (via fn-home) changes 
> it to 100% though.
> 
> I've not seen that behaviour for a very long time and never on the 
> X201. It has been an issue on the X200, which means probably around 
> 2.6.30.

Might make sense to bisect it ... as long as you remember to do this at 
every bisection step that has the hung-suspend bug:

  git cherry-pick 55496c896b8a695140045099d4e0175cf09d4eae

Thanks,

	Ingo

  reply	other threads:[~2010-09-13  8:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10  5:36 2.6.36-rc3 suspend issue (was: 2.6.35-rc4 / X201 issues) Jeff Chua
2010-09-10  7:48 ` Peter Zijlstra
2010-09-10 11:53   ` Jeff Chua
2010-09-10 12:05     ` Peter Zijlstra
2010-09-10 17:19       ` Jeff Chua
2010-09-10 20:32         ` [PATCH] x86, tsc: Fix a preemption leak in restore_sched_clock_state() Peter Zijlstra
2010-09-10 21:01           ` Suresh Siddha
2010-09-11  0:59             ` Jeff Chua
2010-09-11  7:49           ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2010-09-13  7:42             ` Nico Schottelius
2010-09-13  8:46               ` Ingo Molnar [this message]
2010-09-13 22:56                 ` Jeff Chua
2010-09-15  8:03                   ` Nico Schottelius
2010-09-28 11:59                     ` 2.6.36-rc3-00464-g84e1d83 resume issue (was: [tip:sched/urgent] x86, tsc: Fix a preemption leak in restore_sched_clock_state()) Nico Schottelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100913084619.GC23741@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=flo@xssn.at \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nico-linux-20100709@schottelius.org \
    --cc=peterz@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox