Re: [PATCH 2/3] MFD: AB8500 debugfs

Samuel Ortiz
2010-09-13T14:09:19Z

On Mon, Sep 13, 2010 at 03:52:34PM +0200, Mattias Wallin wrote:
>
>
> On 09/13/2010 03:26 PM, Samuel Ortiz wrote:
> > Hi Mattias,
> >
> > I have some addtional comments:
> >
> > On Mon, Sep 13, 2010 at 10:33:02AM +0200, Mattias Wallin wrote:
> >> +static struct platform_driver ab8500_debug_driver = {
> >> + .driver = {
> >> + .name = "ab8500-debug",
> >> + .owner = THIS_MODULE,
> >> + },
> >> + .probe = ab8500_debug_probe,
> >> + .remove = __devexit_p(ab8500_debug_remove)
> >> +};
> >> +
> >> +static int __init ab8500_debug_init(void)
> >> +{
> >> + return platform_driver_register(&ab8500_debug_driver);
> >> +}
> >> +
> >> +static void __exit ab8500_debug_exit(void)
> >> +{
> >> + platform_driver_unregister(&ab8500_debug_driver);
> >> +}
> > It seems a bit awkward to me to have this code as an actual platform driver.
> > Why not defining ab8500_debug_[probe|remove] in ab8500.h as no-op when
> > CONFIG_AB8500_DEBUG is not defined and as extern otherwise ?
> In the register access interface abx500_get_register_interruptible() the first
> argument is a struct *device. This struct *device needs to be a (platform) device "child" to
> the ab8500-core (dev->parent is used).
Obviously. All 3 patches applied, many thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre