From: Greg KH <gregkh@suse.de>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Michal Nazarewicz <m.nazarewicz@samsung.com>,
Maurus Cuelenaere <mcuelenaere@gmail.com>,
linux-usb <linux-usb@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Fabien Chouteau <fabien.chouteau@barco.com>,
david Brownell <dbrownell@users.sourceforge.net>,
Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>,
LKML <linux-kernel@vger.kernel.org>, MeeGo <meego-dev@meego.com>,
"Wang, Qi" <qi.wang@intel.com>,
"Wang, Yong Y" <yong.y.wang@intel.com>,
Andrew <andrew.chih.howe.khor@intel.com>,
Intel OTC <joel.clark@intel.com>,
"Foster, Margie" <margie.foster@intel.com>,
Arjan <arjan@linux.intel.com>,
Toshiharu Okada <okada533@dsn.okisemi.com>,
Takahiro Shimizu <shimizu394@dsn.okisemi.com>,
Tomoya Morinaga <morinaga526@dsn.okisemi.com>
Subject: Re: [PATCH] USB device driver of Topcliff PCH
Date: Mon, 13 Sep 2010 08:29:05 -0700 [thread overview]
Message-ID: <20100913152905.GB24329@suse.de> (raw)
In-Reply-To: <000b01cb52fb$794d2940$66f8800a@maildom.okisemi.com>
On Mon, Sep 13, 2010 at 01:23:40PM +0900, Masayuki Ohtake wrote:
> Hi Greg
>
> > > +#define PCH_UDC_BIT_CLR(reg, bitMask) \
> > > + iowrite32((ioread32((reg)) & (~(bitMask))), (reg))
> >
> >
> > Why not just use the iowrite32 functions directly? Or surely there's
> > another built-in kernel macro for this somewhere, right?
>
> [masa]
> Which macro is it?
> Do you know?
Nope, sorry, try digging around.
good luck,
greg k-h
next prev parent reply other threads:[~2010-09-13 15:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 7:49 [PATCH] USB device driver of Topcliff PCH Masayuki Ohtake
2010-09-07 12:53 ` Maurus Cuelenaere
2010-09-13 4:23 ` Masayuki Ohtake
2010-09-13 10:26 ` Maurus Cuelenaere
2010-09-13 11:31 ` Michał Nazarewicz
2010-09-14 8:35 ` Masayuki Ohtake
2010-09-14 12:50 ` Maurus Cuelenaere
2010-09-14 17:33 ` Valdis.Kletnieks
2010-09-08 0:22 ` Greg KH
2010-09-13 4:23 ` Masayuki Ohtake
2010-09-13 15:29 ` Greg KH [this message]
2010-09-08 1:58 ` Michał Nazarewicz
2010-09-08 13:57 ` Masayuki Ohtake
2010-09-13 4:23 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100913152905.GB24329@suse.de \
--to=gregkh@suse.de \
--cc=andrew.chih.howe.khor@intel.com \
--cc=arjan@linux.intel.com \
--cc=dbrownell@users.sourceforge.net \
--cc=fabien.chouteau@barco.com \
--cc=joel.clark@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=mcuelenaere@gmail.com \
--cc=meego-dev@meego.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=nicolas.ferre@atmel.com \
--cc=okada533@dsn.okisemi.com \
--cc=peter.korsgaard@barco.com \
--cc=qi.wang@intel.com \
--cc=randy.dunlap@oracle.com \
--cc=shimizu394@dsn.okisemi.com \
--cc=siccegge@stud.informatik.uni-erlangen.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox