From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
davem@davemloft.net, perfmon2-devel@lists.sf.net,
eranian@gmail.com, robert.richter@amd.com,
"markus.t.metzger" <markus.t.metzger@intel.com>
Subject: Re: [PATCH] perf_events: improve DS/BTS/PEBS buffer allocation
Date: Mon, 13 Sep 2010 17:51:20 +0200 [thread overview]
Message-ID: <20100913155117.GB6155@nowhere> (raw)
In-Reply-To: <1284392476.2275.369.camel@laptop>
On Mon, Sep 13, 2010 at 05:41:16PM +0200, Peter Zijlstra wrote:
> On Mon, 2010-09-13 at 17:31 +0200, Stephane Eranian wrote:
> > On Mon, Sep 13, 2010 at 5:24 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > > On Mon, 2010-09-13 at 17:20 +0200, Stephane Eranian wrote:
> > >
> > >> That is the case we the sizes you have chosen today. For DS, we
> > >> could round up to one page for now.
> > >
> > > Markus chose the BTS size, for PEBS a single page was plenty since we do
> > > single event things (although we could do multiple for attr.precise_ip <
> > > 2).
> > >
> > > For DS there's:
> > > kmalloc_node(sizeof(struct ds), GFP_KERNEL | __GFP_ZERO, cpu_node(cpu));
> > >
> > Ok, let try again with alloc_pages_node() + kmalloc_node().
> > I think we can stick with kmalloc() for DS because we are far from
> > consuming a page.
>
> Thing is, if you're really seeing allocation failures,
> alloc_pages_node() isn't going to help. And the problem is, these
> allocations aren't movable, so memory compaction and all the other fancy
> stuff aren't really going to help much :/
>
> There was some talk about a function that should sync all of vmalloc
> space, but iirc it was broken for some configs.
Mathieu has posted a set of patches to support traps/faults in NMIs,
this has been followed by a discussion with Linus.
http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-07/msg05222.html
I think they came with some patches to solve the problem, pushing all the
fixup code in the NMI area, but the discussion was preempted by holidays
and I suspect Mathieu is focusing on some other scheduler patches right now :)
next prev parent reply other threads:[~2010-09-13 15:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 14:55 [PATCH] perf_events: improve DS/BTS/PEBS buffer allocation Stephane Eranian
2010-09-13 15:08 ` Peter Zijlstra
2010-09-13 15:21 ` Stephane Eranian
2010-09-13 15:09 ` Frederic Weisbecker
2010-09-13 15:13 ` Stephane Eranian
2010-09-13 15:16 ` Peter Zijlstra
2010-09-13 15:20 ` Stephane Eranian
2010-09-13 15:24 ` Peter Zijlstra
2010-09-13 15:31 ` Stephane Eranian
2010-09-13 15:41 ` Peter Zijlstra
2010-09-13 15:51 ` Frederic Weisbecker [this message]
2010-09-13 15:55 ` Stephane Eranian
2010-09-13 17:35 ` Peter Zijlstra
2010-09-13 18:40 ` Stephane Eranian
2010-09-13 18:42 ` Peter Zijlstra
2010-09-13 18:49 ` Stephane Eranian
2010-09-13 18:57 ` Peter Zijlstra
2010-09-13 19:12 ` Stephane Eranian
2010-09-13 19:31 ` Mathieu Desnoyers
2010-09-13 19:34 ` Peter Zijlstra
2010-09-13 19:35 ` Peter Zijlstra
2010-09-13 19:42 ` Mathieu Desnoyers
2010-09-13 17:24 ` Stephane Eranian
2010-09-13 17:36 ` Peter Zijlstra
2010-09-13 19:35 ` Andi Kleen
2010-09-13 19:49 ` Peter Zijlstra
2010-09-13 20:51 ` Andi Kleen
2010-09-13 20:57 ` [perfmon2] " Luck, Tony
2010-09-13 20:34 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100913155117.GB6155@nowhere \
--to=fweisbec@gmail.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox