public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Kamal Mostafa <kamal@canonical.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Len Brown <lenb@kernel.org>, Matthew Garrett <mjg@redhat.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH] ACPI: sleep: init_set_sci_en_on_resume for Dell Studio 155x
Date: Mon, 13 Sep 2010 19:34:15 +0200	[thread overview]
Message-ID: <201009131934.16027.rjw@sisk.pl> (raw)
In-Reply-To: <1272498183-6094-1-git-send-email-kamal@canonical.com>

On Thursday, April 29, 2010, Kamal Mostafa wrote:
> Add Dell Studio models (1558, 1557, 1555) to the 'set_sci_en_on_resume'
> list to fix hang on resume.
> 
> BugLink: http://bugs.launchpad.net/bugs/553498

This check was removed by commit b6dacf63e9fb2e7a1369843d6cef332f76fca6a3
(ACPI: Unconditionally set SCI_EN on resume), so the patch shouldn't be
necessary.

Thanks,
Rafael


> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> Acked-by: Alex Chiang <achiang@canonical.com>
> Cc: stable@kernel.org
> ---
>  drivers/acpi/sleep.c |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index f74834a..d907c8a 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -458,6 +458,30 @@ static struct dmi_system_id __initdata acpisleep_dmi_table[] = {
>  		DMI_MATCH(DMI_BOARD_NAME, "CF51-2L"),
>  		},
>  	},
> +	{
> +	.callback = init_set_sci_en_on_resume,
> +	.ident = "Dell Studio 1558",
> +	.matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1558"),
> +		},
> +	},
> +	{
> +	.callback = init_set_sci_en_on_resume,
> +	.ident = "Dell Studio 1557",
> +	.matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557"),
> +		},
> +	},
> +	{
> +	.callback = init_set_sci_en_on_resume,
> +	.ident = "Dell Studio 1555",
> +	.matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1555"),
> +		},
> +	},
>  	{},
>  };
>  #endif /* CONFIG_SUSPEND */
> 


  reply	other threads:[~2010-09-13 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-28 23:43 [PATCH] ACPI: sleep: init_set_sci_en_on_resume for Dell Studio 155x Kamal Mostafa
2010-09-13 17:34 ` Rafael J. Wysocki [this message]
2010-09-13 17:44   ` Kamal Mostafa
     [not found] <201004272233.o3RMXLQ6010267@hera.kernel.org>
2010-05-06 17:23 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009131934.16027.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kamal@canonical.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox