From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562Ab0INDXE (ORCPT ); Mon, 13 Sep 2010 23:23:04 -0400 Received: from imr3.ericy.com ([198.24.6.13]:42834 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321Ab0INDXD (ORCPT ); Mon, 13 Sep 2010 23:23:03 -0400 Date: Mon, 13 Sep 2010 20:22:11 -0700 From: Guenter Roeck To: Yong Wang CC: Jean Delvare , Alan Cox , Kalhan Trisal , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" Subject: Re: [lm-sensors] [PATCH] hwmon/emc1403: remove unnecessary hwmon_device_unregister Message-ID: <20100914032211.GA3497@ericsson.com> References: <20100914023351.GA27145@ywang-moblin2.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20100914023351.GA27145@ywang-moblin2.bj.intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2010 at 10:33:51PM -0400, Yong Wang wrote: > It is unnecessary to call hwmon_device_unregister in error handling > before hwmon_device_register is called. > Not only unnecessary but wrong. Good catch. > Signed-off-by: Yong Wang Reviewed-by: Guenter Roeck > --- > drivers/hwmon/emc1403.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c > index 5b58b20..8dee3f3 100644 > --- a/drivers/hwmon/emc1403.c > +++ b/drivers/hwmon/emc1403.c > @@ -308,7 +308,6 @@ static int emc1403_probe(struct i2c_client *client, > res = sysfs_create_group(&client->dev.kobj, &m_thermal_gr); > if (res) { > dev_warn(&client->dev, "create group failed\n"); > - hwmon_device_unregister(data->hwmon_dev); > goto thermal_error1; > } > data->hwmon_dev = hwmon_device_register(&client->dev); > -- > 1.5.5.1 > > > _______________________________________________ > lm-sensors mailing list > lm-sensors@lm-sensors.org > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors