From: Jean Delvare <khali@linux-fr.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Yong Wang <yong.y.wang@linux.intel.com>,
Alan Cox <alan@linux.intel.com>,
Kalhan Trisal <kalhan.trisal@intel.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon/emc1403: remove unnecessary hwmon_device_unregister
Date: Tue, 14 Sep 2010 09:54:52 +0200 [thread overview]
Message-ID: <20100914095452.0d28a221@hyperion.delvare> (raw)
In-Reply-To: <20100914032211.GA3497@ericsson.com>
On Mon, 13 Sep 2010 20:22:11 -0700, Guenter Roeck wrote:
> On Mon, Sep 13, 2010 at 10:33:51PM -0400, Yong Wang wrote:
> > It is unnecessary to call hwmon_device_unregister in error handling
> > before hwmon_device_register is called.
> >
> Not only unnecessary but wrong. Good catch.
>
> > Signed-off-by: Yong Wang <yong.y.wang@intel.com>
>
> Reviewed-by: Guenter Roeck <guenter.roeck@ericsson.com>
Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2010-09-14 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 2:33 [PATCH] hwmon/emc1403: remove unnecessary hwmon_device_unregister Yong Wang
2010-09-14 3:22 ` [lm-sensors] " Guenter Roeck
2010-09-14 7:54 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914095452.0d28a221@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=alan@linux.intel.com \
--cc=guenter.roeck@ericsson.com \
--cc=kalhan.trisal@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=yong.y.wang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox