From: Jean Delvare <khali@linux-fr.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lm-sensors@lm-sensors.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Guenter Roeck <guenter.roeck@ericsson.com>
Subject: Re: [PATCH v2 6/7] hwmon: (lm90) Add support for additional features of max6659
Date: Tue, 14 Sep 2010 13:52:53 +0200 [thread overview]
Message-ID: <20100914135253.6f218514@hyperion.delvare> (raw)
In-Reply-To: <1284038750-8833-7-git-send-email-guenter.roeck@ericsson.com>
Hi Guenter,
On Thu, 9 Sep 2010 06:25:49 -0700, Guenter Roeck wrote:
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Documentation/hwmon/lm90 | 13 ++++++-----
> drivers/hwmon/lm90.c | 51 ++++++++++++++++++++++++++++++++++-----------
> 2 files changed, 45 insertions(+), 19 deletions(-)
> (...)
> @@ -94,7 +94,7 @@ static const unsigned short normal_i2c[] = {
> 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, 0x4d, 0x4e, I2C_CLIENT_END };
>
> enum chips { lm90, adm1032, lm99, lm86, max6657, adt7461, max6680, max6646,
> - w83l771 };
> + w83l771, max6659 };
As the numbers are internal only, it might make sense to group max6657
and max6659 together for better readability.
No other comment, other than the patch ordering (or merging) issue
already pointed out in patch 5/7.
--
Jean Delvare
next prev parent reply other threads:[~2010-09-14 11:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 13:25 [PATCH v2 0/7] hwmon: Add support for MAX6695/6696 to lm90 driver Guenter Roeck
2010-09-09 13:25 ` [PATCH v2 1/7] hwmon: Add tempX_emergency_alarm attribute to sysfs ABI Guenter Roeck
2010-09-13 16:17 ` Jean Delvare
2010-09-13 16:54 ` Guenter Roeck
2010-09-09 13:25 ` [PATCH v2 2/7] hwmon: (lm90) Introduce device feature bits Guenter Roeck
2010-09-13 19:30 ` Jean Delvare
2010-09-13 20:32 ` Guenter Roeck
2010-09-09 13:25 ` [PATCH v2 3/7] hwmon: (lm90) Introduce function to delete sysfs files Guenter Roeck
2010-09-13 19:48 ` Jean Delvare
2010-09-09 13:25 ` [PATCH v2 4/7] hwmon: (lm90) Simplify set_temp11 register calculations Guenter Roeck
2010-09-14 9:18 ` Jean Delvare
2010-09-09 13:25 ` [PATCH v2 5/7] hwmon: (lm90) Introduce 3rd set of upper temperature limits Guenter Roeck
2010-09-14 10:51 ` Jean Delvare
2010-09-14 11:46 ` Guenter Roeck
2010-09-14 11:46 ` [lm-sensors] " Jean Delvare
2010-09-14 12:38 ` Guenter Roeck
2010-09-09 13:25 ` [PATCH v2 6/7] hwmon: (lm90) Add support for additional features of max6659 Guenter Roeck
2010-09-14 11:52 ` Jean Delvare [this message]
2010-09-14 16:08 ` Guenter Roeck
2010-09-09 13:25 ` [PATCH v2 7/7] hwmon: (lm90) Add support for max6695 and max6696 Guenter Roeck
2010-09-15 11:20 ` Jean Delvare
2010-09-15 14:29 ` Guenter Roeck
2010-09-15 14:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914135253.6f218514@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=guenter.roeck@ericsson.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox