From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235Ab0IQF1X (ORCPT ); Fri, 17 Sep 2010 01:27:23 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:53547 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788Ab0IQF1W (ORCPT ); Fri, 17 Sep 2010 01:27:22 -0400 Date: Thu, 16 Sep 2010 22:27:40 -0700 (PDT) Message-Id: <20100916.222740.135972127.davem@davemloft.net> To: drosenberg@vsecurity.com Cc: grundler@parisc-linux.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kyle@mcmartin.ca, jeffm@suse.com, security@kernel.org Subject: Re: [PATCH v3] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl From: David Miller In-Reply-To: <1284699944.2565.4.camel@dan> References: <1284586998.6275.94.camel@dan> <20100916.215313.180410528.davem@davemloft.net> <1284699944.2565.4.camel@dan> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Rosenberg Date: Fri, 17 Sep 2010 01:05:44 -0400 > Now with descriptive title, as requested. > > This was previously reported as a security issue due to leakage of > uninitialized stack memory. Jeff Mahoney pointed out that this is > incorrect since the copied data is from a union (rather than a struct). > Therefore, this patch is only under consideration for the sake of > correctness, and is not security relevant. > > Signed-off-by: Dan Rosenberg > Acked-by: Grant Grundler Tab et al. damaged by your email client. This is getting tiring for me, I guess it's getting tiring for you too? :-)