From: Felipe Balbi <balbi@ti.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: "Balbi, Felipe" <balbi@ti.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
Ming Lei <tom.leiming@gmail.com>,
"greg@kroah.com" <greg@kroah.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Brownell <dbrownell@users.sourceforge.net>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [Discussion] USB: musb-gadget: how to fix ZLP issue in musb_g_tx
Date: Thu, 16 Sep 2010 09:22:32 +0300 [thread overview]
Message-ID: <20100916062232.GC3393@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <AANLkTi=y-HfvDOvhW-WhLFq5TUCjGA-52cuyByCHMvvV@mail.gmail.com>
On Thu, Sep 16, 2010 at 01:15:32AM -0500, Gadiyar, Anand wrote:
>On Thu, Sep 16, 2010 at 11:35 AM, Felipe Balbi <balbi@ti.com> wrote:
>> Hi,
>>
>> On Wed, Sep 15, 2010 at 08:10:15AM -0500, Sergei Shtylyov wrote:
>>>
>>> I don't see what to rework. The last short packet should still satisfy
>>> (request->actual == request->length) condition, no?
>>
>> of course not, it's short not zero. so the last short packet can be
>> anything from 1 to 511 bytes.
>>
>
>If it's TX, both condtions should automatically be true, right?
even in mode1 ? I have to revist my docs, but afaict mode1 won't
transmit last short packet, no matter if it's tx or rx. Could be wrong,
though.
--
balbi
next prev parent reply other threads:[~2010-09-16 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 10:53 [Discussion] USB: musb-gadget: how to fix ZLP issue in musb_g_tx Ming Lei
2010-09-15 10:56 ` Felipe Balbi
2010-09-15 11:02 ` Ming Lei
2010-09-15 11:07 ` Felipe Balbi
2010-09-15 13:10 ` Sergei Shtylyov
2010-09-16 6:05 ` Felipe Balbi
2010-09-16 6:15 ` Gadiyar, Anand
2010-09-16 6:22 ` Felipe Balbi [this message]
2010-09-16 6:54 ` Ming Lei
2010-09-16 11:03 ` Sergei Shtylyov
2010-09-15 11:14 ` Ming Lei
2010-09-15 13:06 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916062232.GC3393@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gadiyar@ti.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sshtylyov@mvista.com \
--cc=tom.leiming@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox