Re: [RFC PATCH] Block device bio throttling support [V3]

[Vivek Goyal <vgoyal@redhat.com>]

On Thu, Sep 16, 2010 at 08:48:05AM +0200, Jens Axboe wrote:
> On 2010-09-15 23:06, Vivek Goyal wrote:
> > Hi,
> > 
> > This is V3 of the bio throttling patches. Following are changes since V2.
> > 
> > - Added the support for throttling in terms of IOPS (READ/WRITE). If one
> >   specifies both bandwidth as well as IOPS rules on a device then IO is
> >   subjected to both the rules.
> > 
> > - Did few bug fixes.
> > 
> > - Did some cleanups in blk-cgroup code.
> 
> Vivek, I have merged these patches now to get some exposure and
> testing before .37 gets too close.

Thanks Jens.

Few things I had in mind.

- I have not implemented any barrier or ordering mechanism in throttling
  logic. I am assuming that all the barrier work to get rid of ordering
  semantics will also go in 2.6.37 and then we really should not need
  to implement any ordering in throttling logic. So it should be a non-issue.

- All throttling logic can simply be disabled by setting
  CONFIG_BLK_DEV_THROTTLING=n. It is already disabled by default. I will
  do some performance testing on faster storage to see what is the cost
  if CONFIG_BLK_DEV_THROTTLING=y and bandwidth is unlimited.

- I am still trying to figure out what to do about max number of bios which
  can be throttled and pending and how to gel it well with request queue
  congestion logic.

Thanks
Vivek