public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: pavan_savoy@ti.com
Cc: alan@lxorguk.ukuu.org.uk, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] prepare ti-st to mv out of staging
Date: Thu, 16 Sep 2010 16:58:29 -0700	[thread overview]
Message-ID: <20100916235829.GA26521@suse.de> (raw)
In-Reply-To: <1284684572-12508-1-git-send-email-pavan_savoy@ti.com>

On Thu, Sep 16, 2010 at 08:49:29PM -0400, pavan_savoy@ti.com wrote:
> From: Pavan Savoy <pavan_savoy@ti.com>
> 
> Greg,
> 
> As suggested, the patch has been spilt to 3 patches:
> 1. corrects the data types
> 2. moves all headers to 1 file
> 3. sources are modified to make use of the newly created header file

Almost.

Never create a patch that breaks the build.  Your patch #2 did that,
right?

Care to merge number 2 and 3 together?

thanks,

greg k-h

  reply	other threads:[~2010-09-16 23:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-17  0:49 [PATCH 0/3] prepare ti-st to mv out of staging pavan_savoy
2010-09-16 23:58 ` Greg KH [this message]
2010-09-17  1:16   ` Savoy, Pavan
2010-09-20 16:16     ` Savoy, Pavan
2010-09-20 17:30       ` Greg KH
2010-09-20 19:19         ` Savoy, Pavan
2010-09-17  0:49 ` [PATCH 1/3] drivers:staging:ti-st: set right the data types pavan_savoy
2010-09-17  0:49   ` [PATCH 2/3] drivers:staging:ti-st: mv headers to ti_wilink_st pavan_savoy
2010-09-17  0:49     ` [PATCH 3/3] drivers:staging:ti-st: use new ti_wilink_st header pavan_savoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100916235829.GA26521@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavan_savoy@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox