From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754930Ab0IQGim (ORCPT ); Fri, 17 Sep 2010 02:38:42 -0400 Received: from 1wt.eu ([62.212.114.60]:45045 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425Ab0IQGik (ORCPT ); Fri, 17 Sep 2010 02:38:40 -0400 Date: Fri, 17 Sep 2010 08:37:54 +0200 From: Willy Tarreau To: David Miller Cc: security@kernel.org, grundler@parisc-linux.org, netdev@vger.kernel.org, drosenberg@vsecurity.com, jeffm@suse.com, linux-kernel@vger.kernel.org, kyle@mcmartin.ca Subject: Re: [Security] [PATCH v4] drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl Message-ID: <20100917063754.GB2341@1wt.eu> References: <1284699944.2565.4.camel@dan> <20100916.222740.135972127.davem@davemloft.net> <1284701436.2565.6.camel@dan> <20100916.223441.93463391.davem@davemloft.net> <20100917063602.GA2341@1wt.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100917063602.GA2341@1wt.eu> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2010 at 08:36:02AM +0200, Willy Tarreau wrote: > On Thu, Sep 16, 2010 at 10:34:41PM -0700, David Miller wrote: > > From: Dan Rosenberg > > Date: Fri, 17 Sep 2010 01:30:36 -0400 > > > > > Tiring doesn't begin to describe it. Formatting undamaged. > > > > :-) Thanks. > > > > > This was previously reported as a security issue due to leakage of > > > uninitialized stack memory. Jeff Mahoney pointed out that this is > > > incorrect since the copied data is from a union (rather than a struct). > > > Therefore, this patch is only under consideration for the sake of > > > correctness, and is not security relevant. > > > > > > Signed-off-by: Dan Rosenberg > > > Acked-by: Grant Grundler > > > > Applied. > > David, just for the record, as was already reported on the list, this > fix is finally more a cleanup than a security fix because "tmp" is a > union and not a struct, so tmp.addr == tmp.lval. sorry, that was already explained in the commit message, next time I'll read it fully before replying :-( Willy