Re: More modaliases + patchtool

Rusty Russell
2010-08-19T00:51:00Z

On Wed, 18 Aug 2010 11:09:30 pm Dzianis Kahanovich wrote:
> First I post into linux-modules@vger.kernel.org, but Jon Masters suggest to
> send this to you. There are some more against maillist:
>
> Some of modules have no MODULE_DEVICE_TABLE(...) and do not export hardware
> ("pnp") aliases, but have all required data to do this. I found it after
> ioatdma module (currently fixed in tree). This information may be useful to
> hardware/modules detection.

> [+] Also known problem: 2 modules (in 2.6.36 state) - scx200_acb.c & pch_dma.c
> - have not NULL-terminated pci_device_id record. This is "easy" to fix, but
> currently I excluding this modules in script. For you I attaching patch for
> this modules and related script ("modulesfix4patched") too.

Thanks, can you format that patch with a simple description and a
Signed-off-by: line and I'll apply it (see Documentation/SubmittingPatches,
especially part 12).

Then can you send me another patch with the results of your script.

Finally, I suggest that your script should only fix files when passed --fix,
and create a config option to run it (without --fix) under in
lib/Kconfig.debug.

Thanks!
Rusty.