Re: #2 (Re: More modaliases + patchtool)

Rusty Russell
2010-09-13T03:24:36Z

On Sun, 12 Sep 2010 03:21:19 am Dmitry Torokhov wrote:
> On Sat, Sep 11, 2010 at 11:44:33AM +0930, Rusty Russell wrote:
> > On Thu, 19 Aug 2010 10:12:36 pm Dzianis Kahanovich wrote:
> > > diff -pruN a/drivers/char/sysrq.c b/drivers/char/sysrq.c
> > > --- a/drivers/char/sysrq.c 2010-08-02 01:11:14.000000000 +0300
> > > +++ b/drivers/char/sysrq.c 2010-08-19 15:23:41.444764991 +0300
> > > @@ -799,4 +799,9 @@ static int __init sysrq_init(void)
> > >
> > > return 0;
> > > }
> > > +
> > > +#ifdef CONFIG_INPUT
> > > +MODULE_DEVICE_TABLE(input, sysrq_ids);
> > > +#endif
> > > +
> > > module_init(sysrq_init);
> >
> > Hmm, Dmitry? Do we want this auto-loaded?
> >
>
> Rusty,
>
> CONFIG_MAGIC_SYSRQ is currently a bool and SysRq support can only be
> built-in.

That seems pretty clear then.

Thanks!
Rusty.
PS. Dmitry, maybe a build with allmodconfig would help eliminate some of
these?