Re: [PATCH 03/10] jump label v11: base patch

Jason Baron
2010-09-21T15:05:26Z

On Tue, Sep 21, 2010 at 04:41:19PM +0200, Andi Kleen wrote:
> > So there are ~150 tracepoints, but this code is also being proposed for
> > use with 'dynamic debug' of which there are > 1000, and I'm hoping for
> > more users moving forward.
>
> Even 1000 is fine to walk, but if it was sorted a binary search
> would be much faster anyways. That is then you would still
> need to search for each module, but that is a relatively small
> number (< 100)
>

yes, but then for each module, I need to again search through the table
to find the correct entires. Although there wouldn't be a 150
tracepoints to search for in each module there are a number of
tracepoints that are used by most modules, such as kmalloc, kfree...plus
any other users of this infrastructure.

> > Also, I think the hash table deals nicely with modules.
>
> Maybe but it's also a lot of code. And it seems to me
> that it is optimizing the wrong thing. Simpler is nicer.
>
> -Andi
>

its right to realize that the enable/disable paths are not at the heart
of this optimization. in fact, the initial few postings of this
patchset, didn't include the hash table, but the added support for
modules lead me to the current design.

thanks,

-Jason