From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Borislav Petkov <borislav.petkov@amd.com>,
Hans Rosenfeld <hans.rosenfeld@amd.com>
Subject: [PATCH 1/3] x86, cacheinfo: Fix dependency of AMD L3 CID
Date: Fri, 17 Sep 2010 18:07:45 +0200 [thread overview]
Message-ID: <20100917160744.GF4958@loge.amd.com> (raw)
In-Reply-To: <20100917155904.GA4958@loge.amd.com>
From: Andreas Herrmann <andreas.herrmann3@amd.com>
L3 cache index disable code uses PCI accesses to AMD northbridge functions.
Currently the code is #ifdef CONFIG_CPU_SUP_AMD.
But it should be #if (defined(CONFIG_CPU_SUP_AMD) && defined(CONFIG_PCI))
which in the end is a dependency to K8_NB.
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/kernel/cpu/intel_cacheinfo.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 898c2f4..2521cdc 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -306,7 +306,7 @@ struct _cache_attr {
ssize_t (*store)(struct _cpuid4_info *, const char *, size_t count);
};
-#ifdef CONFIG_CPU_SUP_AMD
+#ifdef CONFIG_K8_NB
/*
* L3 cache descriptors
@@ -556,12 +556,12 @@ static struct _cache_attr cache_disable_0 = __ATTR(cache_disable_0, 0644,
static struct _cache_attr cache_disable_1 = __ATTR(cache_disable_1, 0644,
show_cache_disable_1, store_cache_disable_1);
-#else /* CONFIG_CPU_SUP_AMD */
+#else /* CONFIG_K8_NB */
static void __cpuinit
amd_check_l3_disable(struct _cpuid4_info_regs *this_leaf, int index)
{
};
-#endif /* CONFIG_CPU_SUP_AMD */
+#endif /* CONFIG_K8_NB */
static int
__cpuinit cpuid4_cache_lookup_regs(int index,
@@ -1000,7 +1000,7 @@ static struct attribute *default_attrs[] = {
static struct attribute *default_l3_attrs[] = {
DEFAULT_SYSFS_CACHE_ATTRS,
-#ifdef CONFIG_CPU_SUP_AMD
+#ifdef CONFIG_K8_NB
&cache_disable_0.attr,
&cache_disable_1.attr,
#endif
--
1.6.4.4
next prev parent reply other threads:[~2010-09-17 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 15:59 [PATCH 0/3 resend] x86: misc K8_NB updates Andreas Herrmann
2010-09-17 16:02 ` [PATCH 2/3] x86, k8-gart: Decouple handling of garts and northbridges Andreas Herrmann
2010-09-17 22:55 ` [tip:x86/amd-nb] " tip-bot for Andreas Herrmann
2010-09-17 16:03 ` [PATCH 3/3] x86, k8: Rename k8.[ch] to amd_nb.[ch] and CONFIG_K8_NB to CONFIG_AMD_NB Andreas Herrmann
2010-09-17 22:55 ` [tip:x86/amd-nb] " tip-bot for Andreas Herrmann
2010-09-20 21:25 ` tip-bot for Andreas Herrmann
2010-09-17 16:05 ` [PATCH 0/3 resend] x86: misc K8_NB updates Andreas Herrmann
2010-09-17 16:07 ` Andreas Herrmann [this message]
2010-09-17 22:55 ` [tip:x86/amd-nb] x86, cacheinfo: Fix dependency of AMD L3 CID tip-bot for Andreas Herrmann
-- strict thread matches above, loose matches on Subject: below --
2010-08-27 7:59 [PATCH] x86, k8-gart: Decouple handling of garts and northbridges Andreas Herrmann
2010-08-31 6:38 ` [PATCH 0/3] x86: misc K8_NB updates Andreas Herrmann
2010-08-31 6:41 ` [PATCH 1/3] x86, cacheinfo: Fix dependency of AMD L3 CID Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917160744.GF4958@loge.amd.com \
--to=herrmann.der.user@googlemail.com \
--cc=borislav.petkov@amd.com \
--cc=hans.rosenfeld@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox