From: Greg KH <gregkh@suse.de>
To: Tim Gardner <tim.gardner@canonical.com>
Cc: linux-kernel@vger.kernel.org, Brett Rudley <brudley@broadcom.com>,
Henry Ptasinski <henryp@broadcom.com>,
Nohee Ko <noheek@broadcom.com>
Subject: Re: [PATCH] staging: brcm80211: Make CFLAGS explicit
Date: Fri, 17 Sep 2010 09:21:42 -0700 [thread overview]
Message-ID: <20100917162142.GA30385@suse.de> (raw)
In-Reply-To: <1284736810-2940-1-git-send-email-tim.gardner@canonical.com>
On Fri, Sep 17, 2010 at 09:20:10AM -0600, Tim Gardner wrote:
> Its too easy to confuse the obscurely named WLC_LOW/WLC_HIGH CFLAG
> macros.
True, but doesn't this change how the code is being built? Why make
this change?
>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> Cc: Brett Rudley <brudley@broadcom.com>
> Cc: Henry Ptasinski <henryp@broadcom.com>
> Cc: Nohee Ko <noheek@broadcom.com>
> ---
> drivers/staging/brcm80211/Makefile | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/Makefile b/drivers/staging/brcm80211/Makefile
> index 05a4103..7a77e7f 100644
> --- a/drivers/staging/brcm80211/Makefile
> +++ b/drivers/staging/brcm80211/Makefile
> @@ -15,8 +15,9 @@
> # OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
> # CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>
> -EXTRA_CFLAGS := -DBCMDBG -DWLC_HIGH -DSTA -DWME -DWL11N -DDBAND -DBCMDMA32 -DBCMNVRAMR -Idrivers/staging/brcm80211/sys -Idrivers/staging/brcm80211/phy -Idrivers/staging/brcm80211/util -Idrivers/staging/brcm80211/include -Wall -Wstrict-prototypes -Werror -Wmissing-prototypes
> +EXTRA_CFLAGS := -DBCMDBG -DWME -DWL11N -DDBAND -DBCMDMA32 -DBCMNVRAMR -Idrivers/staging/brcm80211/sys -Idrivers/staging/brcm80211/phy -Idrivers/staging/brcm80211/util -Idrivers/staging/brcm80211/include -Wall -Wstrict-prototypes -Werror -Wmissing-prototypes
how about 2 patches here, one to break it out into one flag per line so
we can see what is really happening here, and then one patch to make the
change you are asking for.
>
> +USB_CFLAGS := -DWLC_HIGH
Are you sure about this? Why set this when I don't see anything ever
using it?
What problem are you trying to fix here.
totally confused,
greg k-h
next prev parent reply other threads:[~2010-09-17 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 15:20 [PATCH] staging: brcm80211: Make CFLAGS explicit Tim Gardner
2010-09-17 16:21 ` Greg KH [this message]
2010-09-17 17:44 ` Tim Gardner
2010-09-17 17:58 ` Greg KH
2010-09-17 18:03 ` Brett Rudley
2010-09-17 18:33 ` Tim Gardner
2010-09-17 18:39 ` Brett Rudley
[not found] ` <FD96C117992C584DBC47231B1EB6F5568206497F85@SJEXCHCCR02.corp.ad.broadcom.com>
2010-09-21 3:54 ` [PATCH] staging: brcm80211: add fullmac driver Greg KH
2010-09-22 1:56 ` [PATCH] staging: brcm80211: Make CFLAGS explicit matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917162142.GA30385@suse.de \
--to=gregkh@suse.de \
--cc=brudley@broadcom.com \
--cc=henryp@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noheek@broadcom.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox