Re: [PATCH] staging: brcm80211: add fullmac driver

Greg KH
2010-09-21T03:54:44Z

On Mon, Sep 20, 2010 at 07:43:22PM -0700, Nohee Ko wrote:
> This patch to the existing bcm80211 directory in the staging tree adds fullmac driver support for the BCM4329 SDIO chip from Broadcom. Configuration of the mac80211 driver or the fullmac driver can be done through menuconfig.

Please wrap your lines at 72 columns.

Your patch does not apply to the latest linux-next tree. Your patch is
also mime-encoded which probably doesn't help things.

Care to fix this up and resend it so I can apply it?

> --- a/drivers/staging/brcm80211/util/siutils.c
> +++ b/drivers/staging/brcm80211/util/siutils.c
> @@ -59,12 +59,16 @@ static bool si_buscore_prep(si_info_t *sii, uint bustype, uint devid,
> void *sdh);
> static bool si_buscore_setup(si_info_t *sii, chipcregs_t *cc, uint bustype,
> uint32 savewin, uint *origidx, void *regs);
> +#ifndef BRCM_FULLMAC
> static void si_nvram_process(si_info_t *sii, char *pvars);
> +#endif
>
> /* dev path concatenation util */
> +#ifndef BRCM_FULLMAC

<snip>

Why all the #ifdef mess added to the siutils.c file? Is it really
needed? Why not just leave it alone and have the functions always
build.

thanks,

greg k-h