From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753559Ab0IQUuo (ORCPT ); Fri, 17 Sep 2010 16:50:44 -0400 Received: from www.tglx.de ([62.245.132.106]:36033 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782Ab0IQUun (ORCPT ); Fri, 17 Sep 2010 16:50:43 -0400 Date: Fri, 17 Sep 2010 22:50:37 +0200 From: "Hans J. Koch" To: Thomas Gleixner Cc: "Eric W. Biederman" , Greg Kroah-Hartman , "Hans J. Koch" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] uio: Don't clear driver data Message-ID: <20100917205037.GB2522@local> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2010 at 10:33:57PM +0200, Thomas Gleixner wrote: > > > On Tue, 14 Sep 2010, Eric W. Biederman wrote: > > > > > Currently uio sets it's driver data to NULL just as it is unregistering > > attributes. sysfs maks the guaranatee that it will not call attributes > > s/maks/makes/ > > > after device_destroy is called so this is unncessary and leads to lots > > of unnecessary code in uio.c > > > > Signed-off-by: Eric W. Biederman > > Reviewed-by: Thomas Gleixner Signed-off-by: Hans J. Koch