From: Thomas Renninger <trenn@suse.de>
To: Jason Baron <jbaron@redhat.com>
Cc: bjorn.helgaas@hp.com, gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Dynamic Debug: Introduce global fake module param module.ddebug - V3
Date: Fri, 17 Sep 2010 23:52:46 +0200 [thread overview]
Message-ID: <201009172352.46631.trenn@suse.de> (raw)
In-Reply-To: <20100917195456.GA2825@redhat.com>
> Hi,
>
> So i'm wondering if need to support the module.ddebug on the command
> line?
Yep, that would make things a bit easier...
People would e.g. have to use ddebug_query="module pnp +p" (which
already is available with the patch that is queued in linux-next)
instead of pnp.ddebug. Not that obvious or say user friendly, though.
> The ddebug_query="module foo +p" format that you introduced does
> the same thing.
No that does not work for real (not built-in) modules. Give it a try...
The stuff needs to be set up when the module is loaded.
If you have a real module declared as =m
You need to call "module foo +p" when the module gets/got loaded.
But ddebug_query="..." only gets executed once, when
dynamic debug gets set up, far before any module got loaded.
> Also, we can't put those large char[] arrays on the kernel stack. They
> probably should be global.
Where exactly, the command line(*args)?
Thomas
next prev parent reply other threads:[~2010-09-17 21:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 22:11 Dynamic Debug module.ddebug fake param enhancements Thomas Renninger
2010-09-15 22:11 ` [PATCH 1/4] Dynamic Debug: Introduce global fake module param module.ddebug - V3 Thomas Renninger
2010-09-17 19:54 ` Jason Baron
2010-09-17 21:52 ` Thomas Renninger [this message]
2010-09-20 18:44 ` Jason Baron
2010-09-24 12:18 ` Thomas Renninger
2010-09-24 12:28 ` Dynamic Debug module.ddebug fake param enhancements V4 Thomas Renninger
2010-09-24 14:56 ` Bjorn Helgaas
2010-09-27 8:25 ` Thomas Renninger
2010-09-27 15:09 ` Bjorn Helgaas
2010-09-28 12:25 ` Thomas Renninger
2010-09-28 14:22 ` Bjorn Helgaas
2010-10-06 20:59 ` Greg KH
2010-09-24 12:28 ` [PATCH 1/4] Dynamic Debug: Introduce global fake module param module.ddebug - V4 Thomas Renninger
2010-10-06 21:16 ` Greg KH
2010-10-06 21:40 ` Thomas Renninger
2010-10-06 21:51 ` Greg KH
2010-09-24 12:28 ` [PATCH 2/4] PNP: Compile all pnp built-in stuff in one module namespace Thomas Renninger
2010-09-24 12:28 ` [PATCH 3/4] PNP: Use dev_dbg instead of dev_printk(KERN_DEBUG.. if DYNAMIC_DEBUG is compiled in Thomas Renninger
2010-09-24 12:28 ` [PATCH 4/4] kernel/module.c: Fix compiler warnings if debug " Thomas Renninger
2010-09-15 22:11 ` [PATCH 2/4] PNP: Compile all pnp built-in stuff in one module namespace Thomas Renninger
2010-09-15 22:11 ` [PATCH 3/4] PNP: Use dev_dbg instead of dev_printk(KERN_DEBUG.. if DYNAMIC_DEBUG is compiled in Thomas Renninger
2010-09-15 22:11 ` [PATCH 4/4] kernel/module.c: Fix compiler warnings if debug " Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009172352.46631.trenn@suse.de \
--to=trenn@suse.de \
--cc=bjorn.helgaas@hp.com \
--cc=gregkh@suse.de \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox