From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: New compat_alloc_user_space() GPLness and fglrx
Date: Fri, 17 Sep 2010 22:42:32 -0300 [thread overview]
Message-ID: <20100918014232.GA17699@khazad-dum.debian.net> (raw)
commit c41d68a513c71e35a14f66d71782d27a79a81ea6
compat: Make compat_alloc_user_space() incorporate the access_ok()
promotes compat_alloc_user_space() to EXPORT_SYMBOL_GPL, and moves it from
asm/compat.h to linux/compat.h.
This breaks AMD/ATI's proprietary fglrx GPU driver, which wants to use
compat_alloc_user_space(), and expects to find it in asm/compat.h.
Fixing this on the fglrx side is easy enough, one can simply audit the two
or three call sites in the fglrx glue and make sure they can use
arch_compat_alloc_user_space() safely.
But such a fix doesn't look right. IMHO, either we don't want any non-GPL
module touching *_compat_alloc_user_space and compat_alloc_user_space, or it
would be better to let them use compat_alloc_user_space() in the interest of
overall security...
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next reply other threads:[~2010-09-18 1:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 1:42 Henrique de Moraes Holschuh [this message]
2010-09-18 8:26 ` New compat_alloc_user_space() GPLness and fglrx Arnd Bergmann
2010-09-18 12:42 ` Henrique de Moraes Holschuh
2010-09-20 11:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100918014232.GA17699@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=gregkh@suse.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox