The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: john stultz <johnstul@us.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH] Posix CLOCK_RTC interface proof of concept
Date: Sat, 18 Sep 2010 08:15:28 +0200	[thread overview]
Message-ID: <20100918061528.GA3249@riccoc20.at.omicron.at> (raw)
In-Reply-To: <1284748958.2451.68.camel@localhost.localdomain>

On Fri, Sep 17, 2010 at 11:42:38AM -0700, john stultz wrote:
> On Fri, 2010-09-17 at 12:59 +0200, Thomas Gleixner wrote:
> > That's basically a copy of enqueue_hrtimer(). Can't we use
> > k_itimer.it.real for this and reuse the related functions in
> > hrtimer.c? Not sure if it's worth the trouble though.
> 
> Yes, there's also a similar duplication in drivers/char/mmtimer.c and
> Richard Cochran commented on the same (although I'm not sure if he ended
> up using the hrtimer for his similar PTP code).

After taking a look at the hrtimer code, I decided to remove the timer
implementation from the patch set. I do have the userland interface to
timer_create/settime in place, but no clock drivers implement it yet.
 
> I was hoping to find something I could re-use in the hrtimer code, but
> it seemed a little tightly linked to the fixed CLOCK_MONOTONIC/REALTIME
> bases.

That was my impression, too. It looks like hrtimers are hard-coded to
the clock event device via a global per-cpu variable. Would it be
possible to decouple this for multiple, different clock event devices?

Thanks,
Richard

  reply	other threads:[~2010-09-18  6:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16 19:41 [PATCH] Posix CLOCK_RTC interface proof of concept John Stultz
2010-09-17  7:52 ` Richard Cochran
2010-09-17 10:59 ` Thomas Gleixner
2010-09-17 18:42   ` john stultz
2010-09-18  6:15     ` Richard Cochran [this message]
2010-09-18  9:31       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100918061528.GA3249@riccoc20.at.omicron.at \
    --to=richardcochran@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=david-b@pacbell.net \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox