* [PATCH 1/4] alpha: belated ERESTART_RESTARTBLOCK race fix
@ 2010-09-18 8:38 Al Viro
2010-09-19 2:46 ` Michael Cree
0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2010-09-18 8:38 UTC (permalink / raw)
To: linux-kernel; +Cc: Richard Henderson, Linus Torvalds, linux-arch
same thing as had been done on other targets back in 2003 -
move setting ->restart_block.fn into {rt_,}sigreturn().
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
arch/alpha/kernel/signal.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/alpha/kernel/signal.c b/arch/alpha/kernel/signal.c
index 0932dbb..e5b1b3c 100644
--- a/arch/alpha/kernel/signal.c
+++ b/arch/alpha/kernel/signal.c
@@ -239,6 +239,8 @@ restore_sigcontext(struct sigcontext __user *sc, struct pt_regs *regs,
unsigned long usp;
long i, err = __get_user(regs->pc, &sc->sc_pc);
+ current_thread_info()->restart_block.fn = do_no_restart_syscall;
+
sw->r26 = (unsigned long) ret_from_sys_call;
err |= __get_user(regs->r0, sc->sc_regs+0);
@@ -591,7 +593,6 @@ syscall_restart(unsigned long r0, unsigned long r19,
regs->pc -= 4;
break;
case ERESTART_RESTARTBLOCK:
- current_thread_info()->restart_block.fn = do_no_restart_syscall;
regs->r0 = EINTR;
break;
}
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/4] alpha: belated ERESTART_RESTARTBLOCK race fix
2010-09-18 8:38 [PATCH 1/4] alpha: belated ERESTART_RESTARTBLOCK race fix Al Viro
@ 2010-09-19 2:46 ` Michael Cree
2010-09-19 4:50 ` Matt Turner
0 siblings, 1 reply; 3+ messages in thread
From: Michael Cree @ 2010-09-19 2:46 UTC (permalink / raw)
To: Al Viro
Cc: linux-kernel, Richard Henderson, Linus Torvalds, linux-arch,
linux-alpha, mattst88
On 18/09/10 20:38, Al Viro wrote:
> same thing as had been done on other targets back in 2003 -
> move setting ->restart_block.fn into {rt_,}sigreturn().
>
> Signed-off-by: Al Viro<viro@zeniv.linux.org.uk>
For the patch series:
Tested-by: Michael Cree <mcree@orcon.net.nz>
Cheers
Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/4] alpha: belated ERESTART_RESTARTBLOCK race fix
2010-09-19 2:46 ` Michael Cree
@ 2010-09-19 4:50 ` Matt Turner
0 siblings, 0 replies; 3+ messages in thread
From: Matt Turner @ 2010-09-19 4:50 UTC (permalink / raw)
To: Michael Cree
Cc: Al Viro, linux-kernel, Richard Henderson, Linus Torvalds,
linux-arch, linux-alpha
On Sat, Sep 18, 2010 at 10:46 PM, Michael Cree <mcree@orcon.net.nz> wrote:
> On 18/09/10 20:38, Al Viro wrote:
>>
>> same thing as had been done on other targets back in 2003 -
>> move setting ->restart_block.fn into {rt_,}sigreturn().
>>
>> Signed-off-by: Al Viro<viro@zeniv.linux.org.uk>
>
> For the patch series:
>
> Tested-by: Michael Cree <mcree@orcon.net.nz>
>
> Cheers
> Michael.
>
Thanks for the test.
Al, I've vacuumed your patches and sent them with others in a pull
request to Linus.
Thanks a ton. Anyone who finds and fixes a 14 year-old bug, well, I
owe you a beer.
Thanks!
Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-19 4:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-18 8:38 [PATCH 1/4] alpha: belated ERESTART_RESTARTBLOCK race fix Al Viro
2010-09-19 2:46 ` Michael Cree
2010-09-19 4:50 ` Matt Turner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox