From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755499Ab0IRKIb (ORCPT ); Sat, 18 Sep 2010 06:08:31 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:58508 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753364Ab0IRKI3 (ORCPT ); Sat, 18 Sep 2010 06:08:29 -0400 Date: Sat, 18 Sep 2010 11:08:27 +0100 From: Mark Brown To: Phil Carmody Cc: Nishanth Menon , linux-arm , lkml , linux-doc , "H. Peter Anvin" , Jesse Barnes , Madhusudhan Chikkature Rajashekar , Sergio Alberto Aguirre Rodriguez , Andi Kleen , linux-pm , Matthew Garrett , Len Brown , "Valentin Eduardo (Nokia-MS/Helsinki)" , linux-omap , Thara Gopinath , Linus Walleij , Roberto Granados Dorado , "Martin K. Petersen" , Romit Dasgupta , "Kristo Tero (Nokia-MS/Tampere)" , Andrew Morton , Sanjeev Premi Subject: Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs Message-ID: <20100918100827.GC22248@opensource.wolfsonmicro.com> References: <1284686973-13993-1-git-send-email-nm@ti.com> <20100917153643.GC29739@sirena.org.uk> <20100917164543.GI20325@esdhcp04044.research.nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100917164543.GI20325@esdhcp04044.research.nokia.com> X-Cookie: Condense soup, not books! User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2010 at 07:45:43PM +0300, Phil Carmody wrote: > On 17/09/10 17:36 +0200, ext Mark Brown wrote: > > It might be clearer to use some term other than enabled in the code - > > when reading I wasn't immediately sure if enabled meant that it was > > available to be selected or if it was the active operating point. How > ^^^^^^^^^ > > about 'allowed' (though I'm not 100% happy with that)? > I think your query contains its own answer. Yeah, I didn't pick that because all of them are available in the sense that they could in the future be enabled but I do think it's the best option.