From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, lrg@slimlogic.co.uk,
"'Changhwan Youn'" <chaos.youn@samsung.com>,
"'Jeongbae Seo'" <jeongbae.seo@samsung.com>
Subject: Re: [PATCH] regulator: Add support samsung power domain
Date: Mon, 20 Sep 2010 10:50:01 +0100 [thread overview]
Message-ID: <20100920095001.GB31167@sirena.org.uk> (raw)
In-Reply-To: <009d01cb588a$d45ce520$7d16af60$%kim@samsung.com>
On Mon, Sep 20, 2010 at 03:12:34PM +0900, Kukjin Kim wrote:
> The reason the implementation is located in machine-specific code is that
> the way to handle power domain in S5PV210 and S5PV310 is different but we
> can handle this using platform_device_id.
Yes, I think it's reasonable to implement stuff under arch/arm - my only
issue with what you'd done was that I didn't feel the glue layer was
adding anything.
> > Another option to consider here is using runtime PM - other platforms
> > seem to be going down that route, and are using it to also factor clock
> > management for the IP blocks out (so that the block's clocks get enabled
> > and disabled automatically when the block is active without needing any
> > code in the driver).
> To use runtime PM cannot be a substitute for using regulator API.
> It's related to when to control the power domain whether using regulator API
> is to how to control the power domain.
The runtime PM API will give you very similar reference counting to the
regulator API, for all you're using the regulator API for here there's
not a massive difference. If you started using voltage scaling then
there'd be more win.
> We have a plan to support runtime PM using regulator API.
> Am I on the right track ?
That's doable.
prev parent reply other threads:[~2010-09-20 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 9:58 [PATCH] regulator: Add support samsung power domain Kukjin Kim
2010-09-17 11:30 ` Mark Brown
2010-09-17 11:45 ` Marek Szyprowski
2010-09-17 12:07 ` Mark Brown
2010-09-20 6:12 ` Kukjin Kim
2010-09-20 9:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920095001.GB31167@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=chaos.youn@samsung.com \
--cc=jeongbae.seo@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox