public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: liguozhu@huawei.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problem with debugfs
Date: Mon, 20 Sep 2010 20:43:14 -0700	[thread overview]
Message-ID: <20100921034314.GA14062@kroah.com> (raw)
In-Reply-To: <20100921022112.GA10336@localhost>

On Tue, Sep 21, 2010 at 10:21:12AM +0800, liguozhu@huawei.com wrote:
> Hi, there,
> 
> I do not know who is the maintainer for debugfs now.

Did it change?  It's always been me.  I guess I never created a
MAINTAINERS entry, is it really needed?

> But I think there is problem with its API: It uses filp->priv->mutex
> to protect the read/write (to the file) for the value of its
> attribute, but the mutex is not exported to the API user.  Therefore,
> there is no way to protect its value when you directly use the value
> in your module.

What is the problem here, could the value change somehow and you not
like that, or perhaps you read the wrong value from userspace?

Have an example of the issue somewhere?

thanks,

greg k-h

  reply	other threads:[~2010-09-21  3:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21  2:21 Problem with debugfs liguozhu
2010-09-21  3:43 ` Greg KH [this message]
2010-09-21  4:38   ` Randy Dunlap
2010-09-21 13:40     ` Greg KH
2010-09-21  6:13 ` Kenneth
2010-09-21  7:23   ` KOSAKI Motohiro
2010-09-21  7:31     ` Andi Kleen
2010-09-21  8:04       ` Wu Fengguang
2010-09-21  8:12         ` Andi Kleen
2010-09-25  1:18   ` Kenneth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100921034314.GA14062@kroah.com \
    --to=greg@kroah.com \
    --cc=liguozhu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox